List changes #3780
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,28 @@ | ||||||
| Discrete-time variability based on GenerateEvents #3610 | ||||||
|
|
||||||
| # Main change | ||||||
|
Collaborator
There was a problem hiding this comment. Push down:
Suggested change
|
||||||
|
|
||||||
| Variability of functions with GenerateEvents. | ||||||
|
Collaborator
There was a problem hiding this comment. Formatting:
Suggested change
|
||||||
|
|
||||||
| # Reason | ||||||
|
Collaborator
There was a problem hiding this comment. Same as above:
Suggested change
|
||||||
|
|
||||||
| Making it possible to create functions that generate events similarly as the built-in functions, and have rules consistent with them just being inlined. | ||||||
|
|
||||||
| # Breaks | ||||||
|
Collaborator
There was a problem hiding this comment. Same as above:
Suggested change
|
||||||
|
|
||||||
| ``` modelica | ||||||
| function foo | ||||||
| input Real x; | ||||||
| output Integer i=bar(x)+(if x>0 then 1 else 0); | ||||||
| annotation(GenerateEvents=true); | ||||||
| end foo; | ||||||
|
|
||||||
| function bar | ||||||
| input Real x; | ||||||
| output Integer i=integer(x); | ||||||
| annotation(GenerateEvents=false); | ||||||
| end bar; | ||||||
| Integer x=foo(time); | ||||||
| ``` | ||||||
|
|
||||||
| The call of `bar` in `foo` is now illegal, similarly as in a model. | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,8 @@ | ||||||
| This list the semantic changes in the various versions. | ||||||
|
Collaborator
There was a problem hiding this comment. Wording:
Suggested change
|
||||||
|
|
||||||
| Clarifications, examples, reformulations, and changes in layout or other external resources will not be included in this list. | ||||||
|
Collaborator
There was a problem hiding this comment. I thought the plan was to only describe backwards incompatible changes, that is, to not add descriptions of backwards compatible new features? |
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
Comment on lines
+5
to
+6
Collaborator
There was a problem hiding this comment. Redundant:
Suggested change
|
||||||
| The are separate files for each release to make it easy to maintain during development, but may later be merged. | ||||||
|
Collaborator
There was a problem hiding this comment. Typo and clarification:
Suggested change
|
||||||
|
|
||||||
|
Collaborator
There was a problem hiding this comment. Redundant:
Suggested change
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting: