small fixes in getter function examples for CAN in ls-bus-guide #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ClemensB sounds correct or am I missing here something? |
klausschuch
approved these changes
Jun 30, 2025
Contributor
klausschuch
left a comment
klausschuch
left a comment
There was a problem hiding this comment.
Yes, this was a problem im the code snippet and this change fixes it.
I guess it wasn't detected before because the demo FMUs are structured a bit differently with an explicit function call per value reference.
bmenne-dspace
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I have tried the the code snippets from LS-BUS implementers guide.
I think the array index in combination with * is wrong.
Timo