Skip to content

Commit 24590cb

Browse files
committed
clean over-protect getattr
1 parent 432d9c2 commit 24590cb

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

swift/pipelines/infer/rollout.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -295,9 +295,7 @@ def process_weights_after_loading(self) -> None:
295295
*model_config* and *target_device* are available (same as verl);
296296
falls back to FusedMoE-only path otherwise.
297297
"""
298-
model_config = getattr(self.model_runner, 'model_config', None)
299-
if model_config is None:
300-
model_config = getattr(getattr(self, 'vllm_config', None), 'model_config', None)
298+
model_config = self.model_runner.model_config
301299
finish_vllm_weight_reload(self.model_runner.model, model_config=model_config, target_device=self.device)
302300

303301
def close_communicator(self) -> None:
@@ -525,9 +523,7 @@ def _broadcast_obj(obj):
525523
# #42821). Skipped for LoRA sync because the adapter path
526524
# doesn't call ``load_weights``.
527525
if not is_lora_sync:
528-
model_config = getattr(getattr(self, 'model_runner', None), 'model_config', None)
529-
if model_config is None:
530-
model_config = getattr(getattr(self, 'vllm_config', None), 'model_config', None)
526+
model_config = self.model_runner.model_config
531527
finish_vllm_weight_reload(self.model_runner.model, model_config=model_config, target_device=self.device)
532528

533529
if is_lora_sync and all_lora_weights:

0 commit comments

Comments
 (0)