When a Transaction is created, it’s confirmRequired and day members are set. When a transaction is confirmed, it’s confirmedOwners and confirmCount members are updated. When a transaction is considered for execution, it’s data member is populated. Finally, when a transaction is executed, it’s success member is set to true. However, it’s value and amount members are never used.
An owner querying a transaction for approval could still obtain, or at least verify a transaction’s associated value. This could be achieved with WalletMainLib’s getAmount function to extract the amount involved in a token transaction and, if a transaction is known to be a transfer of ether (and the amount of ether is known, as well as the destination address receiving the ether), the id of the transaction could be used to confirm a hypothetical ether value. Both of these are rather cumbersome and technically demanding.
Consider populating the members value and amount upon Transaction creation, or removing these members from the struct altogether.
When a Transaction is created, it’s confirmRequired and day members are set. When a transaction is confirmed, it’s confirmedOwners and confirmCount members are updated. When a transaction is considered for execution, it’s data member is populated. Finally, when a transaction is executed, it’s success member is set to true. However, it’s value and amount members are never used.
An owner querying a transaction for approval could still obtain, or at least verify a transaction’s associated value. This could be achieved with WalletMainLib’s getAmount function to extract the amount involved in a token transaction and, if a transaction is known to be a transfer of ether (and the amount of ether is known, as well as the destination address receiving the ether), the id of the transaction could be used to confirm a hypothetical ether value. Both of these are rather cumbersome and technically demanding.
Consider populating the members value and amount upon Transaction creation, or removing these members from the struct altogether.