Skip to content

Inconsistent requirement for requiredMajor #20

@joshuahannan

Description

@joshuahannan

In WalletAdminLib's checkRequiredChange function, a check is performed to ensure the number of required signatures in a major transaction is at least two less than the number of owners. However, this is never enforced in WalletMainLib's init function, which only requires _requiredMajor to be smaller or equal than the number of owners.
Consider abstracting these requirements into a common function, so as to have consistent behavior in initialization and updating.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions