[Bug]: Shared modules should still be defined even if external

[pcfreak30]

Describe the bug

I have been messing with the plugin and found if you try to externalize things like react or your own shared libraries they will not get put into the manifest or js as even stubs. The goal here is to be shared but call and rely on the global federation module registry instead.

Right now it seems that every bundle duplicates the shared libraries between them, even if it might not use them (ex being a singleton).

Version

6.0.11

Reproduction

will provide later

Relevant log output

Validations

• Read the docs.
• Read the common issues list.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• The provided reproduction is a minimal reproducible example of the bug.

[gioboa]

Hi @pcfreak30 thanks for the report.
Can you share a basic example of this issue?

[pcfreak30]

Hi @pcfreak30 thanks for the report. Can you share a basic example of this issue?

Im doing heavy r&d right now, but I can give you a config.

import { federation } from "@module-federation/vite";
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import path, { dirname, resolve } from "path";
import * as process from "process";
import { fileURLToPath } from "url";
import { defineConfig } from "vite";
import { Plugin } from "vite";

const __dirname = dirname(fileURLToPath(import.meta.url));

export default defineConfig({
  base: "http://localhost:4173",
  build: {
    lib: {
      entry: resolve(__dirname, "src/index.ts"),
      fileName: "index",
      formats: ["es"],
    },
    minify: false,
    rollupOptions: {
      output: {
        minifyInternalExports: false,
      },
    },
    target: "esnext",
  },
  plugins: [
    react(),
    overrideHtmlInjection(),
    federation({
      exposes: {
        ".": "./src/index",
      },
      filename: "remoteEntry-[hash].js",
      manifest: true,
      name: "portal-framework-plugin-core",
      remotes: {},
      shared: {
        "@lumeweb/portal-framework-core": {
          singleton: true,
        },
        "react": {
          singleton: true,
        },
        "react-dom": {
          singleton: true,
        },
        "react-router": {
          singleton: true,
        },
      },
    }),
  ],
});

this works. but if i add the shared deps to external it does NOT. the goal here is to not duplicate dependencies between federated modules so when the parent bundles it the child can reference the registry, and not bring its own copy it wont use.

In the current impl I found the customResolver's in the proxySharedModule never get triggered if in external so special support may be needed to ensure it both does, and routes in the generated shims correctly.

[gioboa]

I see, feel free to drop a PR if you need library improvements