Merge PR OCA#4987 into 16.0

OCA-git-bot · OCA-git-bot · commit 5476efdce8a4 · 2026-05-07T14:02:13.000Z
Signed-off-by pedrobaeza
diff --git a/l10n_es_facturae/models/account_move.py b/l10n_es_facturae/models/account_move.py
@@ -225,7 +225,7 @@ def _get_facturae_move_attachments(self):
             description, content_type = attachment.filename.rsplit(".", 1)
             result.append(
                 {
-                    "data": attachment.file,
+                    "data": attachment.file.decode("utf-8"),
                     "content_type": content_type,
                     "encoding": "BASE64",
                     "description": description,
diff --git a/l10n_es_facturae/tests/common.py b/l10n_es_facturae/tests/common.py
@@ -340,6 +340,11 @@ def test_facturae_with_extra_attachments(self):
                 ]
             }
         )
+        # Ensure attachments data is correctly decoded on base64
+        attachments = self.move._get_facturae_move_attachments()
+        for attachment in attachments:
+            self.assertFalse(isinstance(attachment["data"], bytes))
+            self.assertTrue(isinstance(attachment["data"], str))
         generated_facturae = self._create_facturae_file(self.move, force=True)
         self.assertTrue(
             generated_facturae.xpath(

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ def _get_facturae_move_attachments(self):`
`225`	`225`	`description, content_type = attachment.filename.rsplit(".", 1)`
`226`	`226`	`result.append(`
`227`	`227`	`{`
`228`		`- "data": attachment.file,`
	`228`	`+ "data": attachment.file.decode("utf-8"),`
`229`	`229`	`"content_type": content_type,`
`230`	`230`	`"encoding": "BASE64",`
`231`	`231`	`"description": description,`
Original file line number	Diff line number	Diff line change
`@@ -340,6 +340,11 @@ def test_facturae_with_extra_attachments(self):`
`340`	`340`	`]`
`341`	`341`	`}`
`342`	`342`	`)`
	`343`	`+ # Ensure attachments data is correctly decoded on base64`
	`344`	`+ attachments = self.move._get_facturae_move_attachments()`
	`345`	`+ for attachment in attachments:`
	`346`	`+ self.assertFalse(isinstance(attachment["data"], bytes))`
	`347`	`+ self.assertTrue(isinstance(attachment["data"], str))`
`343`	`348`	`generated_facturae = self._create_facturae_file(self.move, force=True)`
`344`	`349`	`self.assertTrue(`
`345`	`350`	`generated_facturae.xpath(`