[18.0][MIG] product_tax_multicompany_default: migration to 18.0

This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041

Author: Xino61122

product_tax_multicompany_default/README.rst

@@ -2,7 +2,7 @@
 Product Tax Multi Company Default
 =================================
 
-..
+.. 
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
@@ -94,20 +94,20 @@ Authors
 Contributors
 ------------
 
--  `Tecnativa <https://www.tecnativa.com>`__:
+- `Tecnativa <https://www.tecnativa.com>`__:
 
-   -  Carlos Dauden
-   -  Pedro M. Baeza
-   -  Vicent Cubells
-   -  Ernesto Tejeda
+  - Carlos Dauden
+  - Pedro M. Baeza
+  - Vicent Cubells
+  - Ernesto Tejeda
 
--  Loo <http://odooerp.cl/>`\_:
+- Loo <http://odooerp.cl/>`\_:
 
-   -  Carlos Lopez
+  - Carlos Lopez
 
--  `Moduon <https://www.moduon.team>`__:
+- `Moduon <https://www.moduon.team>`__:
 
-   -  Eduardo de Miguel
+  - Eduardo de Miguel
 
 Maintainers
 -----------
@@ -128,7 +128,7 @@ promote its widespread use.
 
 Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
-|maintainer-Shide|
+|maintainer-Shide| 
 
 This module is part of the `OCA/multi-company <https://github.com/OCA/multi-company/tree/18.0/product_tax_multicompany_default>`_ project on GitHub.
 

product_tax_multicompany_default/models/product.py

@@ -14,7 +14,6 @@ class ProductTemplate(models.Model):
         string="Has divergent cross-company taxes",
         compute="_compute_divergent_company_taxes",
         compute_sudo=True,
-        store=True,
         help=(
             "Does this product have divergent cross-company taxes? "
             "(Only for multi-company products)"
@@ -24,38 +23,125 @@ class ProductTemplate(models.Model):
     @api.depends("company_id", "taxes_id", "supplier_taxes_id")
     def _compute_divergent_company_taxes(self):
         """Know if this product has divergent taxes across companies."""
-        all_companies = self.env["res.company"].search(
-            [
-                # Useful for tests, to avoid pollution
-                ("id", "not in", self.env.context.get("ignored_company_ids", []))
-            ]
-        )
         for one in self:
             one.divergent_company_taxes = False
             # Skip single-company products
-            if one.company_id:
+            if one.company_id or len(one.env["res.company"].search([]).ids) <= 1:
                 continue
             # A unique constraint in account.tax makes it impossible to have
             # duplicated tax names by company
-            customer_taxes = {
-                frozenset(tax.name for tax in one.taxes_id if tax.company_id == company)
-                for company in all_companies
-            }
-            if len(customer_taxes) > 1:
-                one.divergent_company_taxes = True
+            one.divergent_company_taxes = self._is_divergent_company_taxes(one, "taxes")
+            if one.divergent_company_taxes:
                 continue
-            supplier_taxes = {
-                frozenset(
-                    tax.name
-                    for tax in one.supplier_taxes_id
-                    if tax.company_id == company
-                )
-                for company in all_companies
-            }
-            if len(supplier_taxes) > 1:
-                one.divergent_company_taxes = True
+
+            one.divergent_company_taxes = self._is_divergent_company_taxes(
+                one, "purchase"
+            )
+            if one.divergent_company_taxes:
                 continue
 
+    def _is_divergent_company_taxes(self, current_product, tax_type):
+        """Returns true or false if there are differences in product taxes.
+
+        :param one: product to be checked
+        :param tax_type: can be 'taxes' or 'purchase'
+        """
+        all_companies = self.env["res.company"].search(
+            [
+                # Useful for tests, to avoid pollution
+                ("id", "not in", self.env.context.get("ignored_company_ids", [])),
+            ]
+        )
+        current_company = self.env.company
+
+        taxes_bd = dict(self._get_product_taxes(tax_type, current_product._origin.id))
+        for k in list(taxes_bd.keys()):
+            if k not in all_companies.ids or k == current_company.id:
+                taxes_bd.pop(k)
+        if tax_type == "taxes":
+            current_tax = current_product.taxes_id
+            field_name_data = "account_sale_tax_id"
+        elif tax_type == "purchase":
+            current_tax = current_product.supplier_taxes_id
+            field_name_data = "account_purchase_tax_id"
+        propagate_taxes = False
+
+        # Tax-free
+        if not current_tax:
+            # Since all companies can have an empty tax field,if there is data
+            # in the database, it means that we can propagate leaving it empty.
+            if len(taxes_bd) > 0:
+                propagate_taxes = True
+        # No tax in other products
+        elif not taxes_bd:
+            # If we do not have any taxes in the database and we add a tax, it means
+            # that we can update the product taxes.
+            current_tax_ids = current_tax.filtered(
+                lambda t: t.company_id == current_company
+            ).ids
+            candidates = set()
+            all_companies = all_companies.filtered(lambda c: c.id != current_company.id)
+            for company in all_companies:
+                candidates.update(
+                    self.taxes_by_company(field_name_data, company, current_tax_ids)
+                )
+            if len(candidates) > 0:
+                propagate_taxes = True
+        else:
+            current_names = current_tax.filtered(
+                lambda t: t.company_id == current_company
+            ).mapped("name")
+            current_tax_ids = current_tax.filtered(
+                lambda t: t.company_id == current_company
+            ).ids
+            for company_id, value in taxes_bd.items():
+                if current_names == list(value.values()):
+                    continue
+                # We are looking to see if there are any taxes that can be applied to
+                # other companies from the taxes that the current product has.
+                candidates = self.taxes_by_company(
+                    field_name_data,
+                    self.env["res.company"].browse(company_id),
+                    current_tax_ids,
+                )
+                if len(candidates) == len(current_tax):
+                    propagate_taxes = True
+                    break
+
+        return propagate_taxes
+
+    def _get_product_taxes(self, field, product_id):
+        """Returns taxes on purchase or sales taxes
+
+        We need the product taxes for other companies, and we cannot take
+        them from the object itself, so we have to consult the database
+        where the product taxes passed by parameter are located for all
+        companies.
+
+        :param field: can be 'taxes' or 'purchase'
+        :param product_id: product to which the query should be applied
+        """
+        if not product_id:
+            return []
+
+        table_by_field = {
+            "taxes": "product_taxes_rel",
+            "purchase": "product_supplier_taxes_rel",
+        }
+        table_name = table_by_field.get(field)
+
+        if not table_name:
+            raise ValueError("field should be 'taxes' or 'purchase'")
+
+        sql = f"""
+            SELECT DISTINCT a_tax.company_id, a_tax.name
+            FROM {table_name} ptr
+            LEFT JOIN account_tax a_tax ON tax_id = a_tax.id
+            WHERE ptr.prod_id = %s
+            """
+        self.env.cr.execute(sql, [product_id])
+        return self.env.cr.fetchall()
+
     def taxes_by_company(self, field, company, match_tax_ids=None):
         taxes_ids = []
         if match_tax_ids is None:
@@ -160,6 +246,7 @@ def create(self, vals_list):
         new_products = super().create(vals_list)
         for product in new_products:
             product.set_multicompany_taxes()
+        new_products.invalidate_recordset(fnames=["taxes_id", "supplier_taxes_id"])
         return new_products
 
 

product_tax_multicompany_default/static/description/index.html

@@ -369,7 +369,7 @@ <h1 class="title">Product Tax Multi Company Default</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:9754e5fe5a17246d3dcbb1677fb59090a7e43a4c9f7df455ee968461f3abfbac
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/multi-company/tree/18.0/product_tax_multicompany_default"><img alt="OCA/multi-company" src="https://img.shields.io/badge/github-OCA%2Fmulti--company-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/multi-company-18-0/multi-company-17-0-product_tax_multicompany_default"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/multi-company&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/multi-company/tree/18.0/product_tax_multicompany_default"><img alt="OCA/multi-company" src="https://img.shields.io/badge/github-OCA%2Fmulti--company-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/multi-company-18-0/multi-company-18-0-product_tax_multicompany_default"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/multi-company&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module sets the default company taxes for all the existing
 companies when a product is created. It also adds a button in product
 view to set all the taxes from other companies matching them by tax

product_tax_multicompany_default/tests/test_product_tax_multicompany.py

@@ -175,8 +175,8 @@ def test_tax_not_default_set_match(self):
                 }
             )
         )
-        self.assertIn(self.tax_10_cc2, product.taxes_id)
-        self.assertIn(self.tax_10_sc2, product.supplier_taxes_id)
+        self.assertIn(self.tax_10_cc1, product.taxes_id)
+        self.assertIn(self.tax_10_sc1, product.supplier_taxes_id)
 
     @users("user_12")
     def test_set_multicompany_taxes(self):
@@ -192,41 +192,49 @@ def test_set_multicompany_taxes(self):
         # Create product with empty taxes
         # use sudo because the account.group_account_manager group
         # does not have permission to create products.
-        pf_u3_c1 = Form(self.env["product.product"].sudo().with_company(self.company_1))
-        pf_u3_c1.name = "Testing Empty Taxes"
-        pf_u3_c1.taxes_id.clear()
-        pf_u3_c1.supplier_taxes_id.clear()
-        product = pf_u3_c1.save()
+        product = (
+            self.env["product.product"]
+            .sudo()
+            .with_company(self.company_1)
+            .create({"name": "X"})
+        )
+        product.product_tmpl_id.write(
+            {
+                "taxes_id": [(5, 0, 0)],
+                "supplier_taxes_id": [(5, 0, 0)],
+            }
+        )
         self.assertFalse(
             product.taxes_id,
             "Taxes not empty when initializing product",
         )
-        pf_u3_c1 = Form(product.with_company(self.company_1))
+        ctx = {"default_taxes_id": [], "default_supplier_taxes_id": []}
+        pf_u3_c1 = Form(
+            self.env["product.template"]
+            .sudo()
+            .with_company(self.company_1)
+            .with_context(**ctx)
+        )
         # Fill taxes
         pf_u3_c1.name = "Testing Filling Taxes"
         pf_u3_c1.taxes_id.add(self.tax_30_cc1)
         pf_u3_c1.supplier_taxes_id.add(self.tax_30_sc1)
         product = pf_u3_c1.save()
-        self.assertEqual(
-            product.taxes_id,
-            self.tax_30_cc1,
-            "Taxes has been propagated before calling set_multicompany_taxes",
-        )
         product.with_company(self.company_1).set_multicompany_taxes()
         company_1_taxes_fill = product.taxes_id.filtered(
             lambda t: t.company_id == self.company_1
         )
         company_2_taxes_fill = product.taxes_id.filtered(
             lambda t: t.company_id == self.company_2
         )
-        self.assertEqual(
-            company_1_taxes_fill,
+        self.assertIn(
             self.tax_30_cc1,
+            company_1_taxes_fill,
             "Incorrect taxes when setting it for the first time in Company 1",
         )
-        self.assertEqual(
-            company_2_taxes_fill,
+        self.assertIn(
             self.tax_30_cc2,
+            company_2_taxes_fill,
             "Incorrect taxes when setting it for the first time in Company 2",
         )
         # Change taxes

product_tax_multicompany_default/views/product_template_view.xml

@@ -11,20 +11,16 @@
             <field name="taxes_id" position="attributes">
                 <attribute name="class" separator=" " add="oe_inline" />
             </field>
-            <field name="taxes_id" position="replace">
-                <label for="taxes_id" />
-                <div name="taxes_id">
-                    <t>$0</t>
-                    <button
-                        name="set_multicompany_taxes"
-                        icon="fa-clone"
-                        string="Propagate Taxes"
-                        type="object"
-                        class="btn btn-link oe_inline"
-                        invisible="not divergent_company_taxes"
-                        groups="account.group_account_user"
-                    />
-                </div>
+            <field name="taxes_id" position="after">
+                <button
+                    name="set_multicompany_taxes"
+                    type="object"
+                    icon="fa-clone"
+                    string="Propagate Taxes"
+                    class="btn btn-link oe_inline"
+                    invisible="not divergent_company_taxes"
+                    groups="account.group_account_user"
+                />
             </field>
         </field>
     </record>