Skip to content

Commit d1f8d11

Browse files
committed
fix page and chunk selector in TV and Theme Settings
Signed-off-by: matdave <[email protected]>
1 parent fe9df81 commit d1f8d11

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

Diff for: _build/assets/js/Components/Sidebar/PageSettings.js

+10-4
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,9 @@ export default class PageSettings extends SidebarPlugin {
255255
case 'slider':
256256
return ui.slider(setting, defaultValue, this.setThemeSettingWithEmitter);
257257
case 'page':
258-
return ui.page(setting, defaultValue, this.setThemeSettingWithEmitter);
258+
return ui.page(setting, {id: defaultValue, url: ''}, this.setThemeSettingWithEmitter);
259259
case 'chunk':
260-
return ui.chunk(setting, defaultValue, this.setThemeSettingWithEmitter);
260+
return ui.chunk(setting, {id: defaultValue, name: ''}, this.setThemeSettingWithEmitter);
261261
case 'tagger':
262262
return ui.tagger(setting, defaultValue, this.setThemeSettingWithEmitter);
263263
case 'image':
@@ -361,7 +361,7 @@ export default class PageSettings extends SidebarPlugin {
361361
fields.appendChild(ui.slider(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
362362
break;
363363
case 'page':
364-
fields.appendChild(ui.page(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
364+
fields.appendChild(ui.page(tv, { id: this.pageSettings.tvs[tv.name], url: ''}, this.setTVWithEmitter, this.addTVChangeListener));
365365
break;
366366
case 'tagger':
367367
fields.appendChild(ui.tagger(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
@@ -387,7 +387,7 @@ export default class PageSettings extends SidebarPlugin {
387387
fields.appendChild(ui.toggleGroup(tv, this.pageSettings.tvs[tv.name], this.setMultiTVWithEmitter, this.addTVChangeListener));
388388
break;
389389
case 'chunk':
390-
fields.appendChild(ui.chunk(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
390+
fields.appendChild(ui.chunk(tv, { id: this.pageSettings.tvs[tv.name], name: ''}, this.setTVWithEmitter, this.addTVChangeListener));
391391
default:
392392
fields.appendChild(ui.text(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
393393
}
@@ -436,6 +436,9 @@ export default class PageSettings extends SidebarPlugin {
436436
}
437437

438438
setThemeSettingWithEmitter(name, value, input) {
439+
if (typeof value === 'object' && value.id) {
440+
value = value.id;
441+
}
439442
this.setThemeSetting(name, value);
440443

441444
emitter.emit('fred-theme-setting-change', name, value, valueParser(value), input);
@@ -472,6 +475,9 @@ export default class PageSettings extends SidebarPlugin {
472475
}
473476

474477
setTVWithEmitter(name, value, input) {
478+
if (typeof value === 'object' && value.id) {
479+
value = value.id;
480+
}
475481
this.setSetting(name, value, 'tvs');
476482
emitter.emit('fred-page-setting-change', 'tv_' + name, value, valueParser(value), input);
477483
}

0 commit comments

Comments
 (0)