Skip to content

Commit 03923e6

Browse files
authored
Fix empty attributes when special characters appear in package readme (#16713)
### What does it do? Change htmlentities to htmlspecialchars ### Why is it needed? In one of my packages I have used a `ß` in the readme for the transport package. When this transport package is installed, the result the of `Workspace/Packages/GetAttribute` processor is empty for some reason inside of the Parsedown class in combination with the processor response and the package can't be installed anymore. ### How to test Add a `ß` in the readme of a transport package. ### Related issue(s)/PR(s) None known
1 parent 2533619 commit 03923e6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: core/src/Revolution/Processors/Workspace/Packages/GetAttribute.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public function process()
7878
foreach ($attributesToGet as $attribute) {
7979
$data = $this->transport->getAttribute($attribute);
8080
$attributes[$attribute] = in_array($attribute,
81-
['changelog', 'license', 'readme']) ? $parseDown->text(htmlentities($data)) : $data;
81+
['changelog', 'license', 'readme']) ? $parseDown->text(htmlspecialchars($data)) : $data;
8282

8383
/* if setup options, include setup file */
8484
if ($attribute === 'setup-options') {

0 commit comments

Comments
 (0)