Skip to content

Commit ab23a8e

Browse files
matdaveopengeek
andauthored
Add z-index to x-form-item class (#16712)
### What does it do? Primary goal is to add z-index to x-form-item class. During setup of my test environment I noticed some critical vulnerabilities were unaddressed in the package generation files, so I corrected those as well. ### Why is it needed? Fixes an issue where the form items can overlap the menu bar, making the menu unclickable. ### How to test Open a file to edit in the manager. Scroll down until "Content" -> "Clear Cache" -> "Refresh URIs" opens over one of the field labels. Without the fix the text will appear over "Refresh URIs" making it hard to click. The same happens if you do this for checkboxes and certain other field elements. ### Related issue(s)/PR(s) #16711 --------- Co-authored-by: Jason Coward <[email protected]>
1 parent d170c00 commit ab23a8e

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

_build/templates/default/sass/_forms.scss

+1
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ input::-moz-focus-inner {
114114
margin: 0;
115115
outline: 0 none; /* prevent firefox from creating ugly dotted outlines */
116116
position: relative; /* boundary for absolutely positioned elements */
117+
z-index: 1;
117118

118119
/* general styles for form labels, paddings for various form layouts are handled below */
119120
label.x-form-item-label {

_build/templates/default/sass/_tabs.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ ul.x-tab-strip li {
8585
margin-left: 0;
8686
padding: 0 12px;
8787
position: relative;
88-
z-index: 5;
88+
z-index: 1;
8989

9090
html[dir="rtl"] & {
9191
float: right;

manager/templates/default/css/index-min.css

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

manager/templates/default/css/index.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -20838,6 +20838,7 @@ input::-moz-focus-inner {
2083820838
/* prevent firefox from creating ugly dotted outlines */
2083920839
position: relative;
2084020840
/* boundary for absolutely positioned elements */
20841+
z-index: 1;
2084120842
/* general styles for form labels, paddings for various form layouts are handled below */
2084220843
/* label.x-form-item-label */
2084320844
/* is outside of the label */
@@ -22938,7 +22939,7 @@ ul.x-tab-strip li {
2293822939
margin-left: 0;
2293922940
padding: 0 12px;
2294022941
position: relative;
22941-
z-index: 5;
22942+
z-index: 1;
2294222943
}
2294322944
html[dir=rtl] ul.x-tab-strip li {
2294422945
float: right;

0 commit comments

Comments
 (0)