Variable naming in the config.inc.php file

[shamblett]

shamblett created Redmine issue ID 10479

Some variables in the config.inc.php file start with '$modx_' but most don't. This is not a problem unless you are using this file to create a MODx object in API mode only, possibly embedding this in a 3rd party application say. When you include the config.inc.php file these generic names such as '$http_host' pollute the environment downstream of the include and can cause difficult to find errors. Prefixing all these variables with '$modx_' would help to alleviate this and provide consistency.

[OptimusCrime]

I agree, it would make a lot more sense to prefix everything with $modx in the config-file.

[garryn]

Definitely one for MODX 3.0, it's a potential breaking change to change those variable names and any breaking changes need to happen in the next major release.

[eco-line]

config.inc.php is located in which folder ?

[OptimusCrime]

core/config I belive

[Ruslan-Aleev]

It also makes sense to place related fields side by side, for example, $dbase and $database_user, since the fields often have the same values and it will be easier to edit them visually.
Logically connected with #14238

[Ruslan-Aleev]

By the way, there are lines in the config:

$database_type = 'mysql';
$database_server = 'localhost';
$database_user = 'db_user';
$database_connection_charset = 'utf8';
$dbase = 'db_name';
...
$database_dsn = 'mysql:host=localhost;dbname=db_name;charset=utf8';

But why variables ($database_type, $database_server, $dbase and other) are not used in $database_dsn, but data needs to be specified again.

[sergant210]

$database_dsn = "mysql:host=$database_server;dbname=$dbase;charset=$database_connection_charset";