Better handling of deprecated TV types and removed TV types

[Jako]

Summary

It has to be solved that deprecated TV types are not selectable anymore and not existing old TV types (i.e. removed custom TV types) could create a fatal error. Some fallback to a default TV type should be implemented.

Step to reproduce

At the moment the Textarea (mini) TV type is still visible in newer MODX installations, if it is assigned to a TV. Also custom TV types assigned to a TV are still using that TV custom type when the custom TV type extra is uninstalled. That causes a fatal error in the backend during editing a resource with that TV assigned (for deprecated TV types since MODX 2.5.0).

Observed behavior

Fatal error during editing a resource using that TV.

Expected behavior

No fatal error and a fallback to i.e. textarea TV. I would prefer a textarea TV, since a custom TV value could contain multiple lines, quotes etc.

Environment

All MODX versions, see #13066

[pixelchutes]

Is there currently a built-in way for determining the list of supported TV types? Something that could be easily cross-referenced w/ the database? I really like the fallback idea (to prevent the fatal), but how best to inform the editor of the underlying TV problem + fix?

[Jako]

There could be a getlist processor for the dropdown.

[pixelchutes]

@Jako, ah -- makes perfect sense!

element/tv/renders/getInputs

{
    "success": true,
    "total": "18",
    "results": [{
        "name": "Auto-Tag",
        "value": "autotag"
    }, {
        "name": "Check Box",
        "value": "checkbox"
    }, {
        "name": "Date",
        "value": "date"
    }, {
        "name": "Email",
        "value": "email"
    }, {
        "name": "File",
        "value": "file"
    }, {
        "name": "Hidden",
        "value": "hidden"
    }, {
        "name": "Image",
        "value": "image"
    }, {
        "name": "Legacy multiple list",
        "value": "list-multiple-legacy"
    }, {
        "name": "Listbox (Multi-Select)",
        "value": "listbox-multiple"
    }, {
        "name": "Listbox (Single-Select)",
        "value": "listbox"
    }, {
        "name": "Number",
        "value": "number"
    }, {
        "name": "Radio Options",
        "value": "option"
    }, {
        "name": "Resource List",
        "value": "resourcelist"
    }, {
        "name": "RichText",
        "value": "richtext"
    }, {
        "name": "Tag",
        "value": "tag"
    }, {
        "name": "Text",
        "value": "text"
    }, {
        "name": "Textarea",
        "value": "textarea"
    }, {
        "name": "URL",
        "value": "url"
    }]
}

[pixelchutes]

Looks like it uses DirectoryIterator and loops through php TV input files located in core/model/modx/processors/element/tv/renders/mgr/input/ (provided you're in mgr context), plus any custom directories defined in a Plugin bound on OnTVInputRenderList, or from namespace caches.