Need refactoring of lexicon topics

[Ruslan-Aleev]

Feature request

Summary

Lexicon topics contain unnecessary entries, for example, in the chunk.inc.php topic there is an entry with the key "chunk" - https://github.com/modxcms/revolution/blob/2.x/core/lexicon/en/chunk.inc.php#L9, but the same entry with the key "chunk" is in the topic https://github.com/modxcms/revolution/blob/2.x/core/lexicon/en/default.inc.php#L58 which is always included in MODX manager.
Why do we need 2 entries for one key?

There are also duplicate entries within the meaning, but with a different key - https://github.com/modxcms/revolution/blob/2.x/core/lexicon/en/default.inc.php#L18 and https://github.com/modxcms/revolution/blob/2.x/core/lexicon/en/default.inc.php#L272 is already a problem with incorrect key names, see PR #14313.

There are unnecessary entries, for example, "Edit TV", "Edit chunk", but it is easier to use one "Edit" entrie
for both TV and chunk. Why such specific entries for the element? There are not only extra lines in the topics, but errors in the code, i.e. used, for example, and "create" and "create_ELEMENT" at the same time, etc.

There are also entries that are written in the wrong topic.

We need to correctly distribute the entries in the topics, remove unnecessary and remove unused.

Related issue(s)/PR(s)

#14313
#13554
#1188

[Ruslan-Aleev]

In the code, lexicons are output in several ways:

• [[%lexicon]] (in .tpl)
• _('lexicon') (in .js)
• return $this->modx->('lexicon') (in .php)
• return $this->modx->lexicon($this->objectType . '_err_nf') (dynamically in .php, mainly for errors), for example - https://github.com/modxcms/revolution/blob/3.x/core/src/Revolution/Processors/Element/Create.php#L57
• maybe there are still output options

---

Quickly checking the lexicons, it seems to me that about 40-50% (so many) of the lexicons are not used.
And this is extremely unpleasant for working with translation.

[Jako]

I have created a lexicon checker in GPM, that has a few regular expressions to cover all the strings you mentioned. Maybe you could check the MODX core with a similar method?

https://github.com/theboxer/Git-Package-Management/blob/master/core/components/gitpackagemanagement/processors/mgr/gitpackage/checklexicon.class.php

[Ruslan-Aleev]

@Jako Thanks for the script! Unfortunately, I do not have enough experience for this.
If you have the opportunity and time, can you help with PR? Useful improvements before the release of MODX3.

[Jako]

i could add something into _build (or whereever this should be placed) next week to make a semi automatic check possible.

[JoshuaLuckers]

What happens to extra's/developers that are using the lexicon that might/might not be in use by the core?

[Jako]

3.0 would be a good time for doing that.

[Jako]

An initial check is prepared. It has to be checked for 3.x.