The system setting "cache_format" must be removed.

[sergant210]

Bug report

Summary

The "cache_format" system setting must be removed from the settings list in the same way as "cache_system_settings".

Step to reproduce

Try to set it to 1 or 2 and back.

Observed behavior

Site will crash.

[JoshuaLuckers]

We need to investigate why the site is crashing when changing the value before we decide to remove the setting.

Can you provide some additional information about your environment?

[Ruslan-Aleev]

This is clearly something with caching :) Don't you have this bug?

If you change the setting, clear the cache in panel, then the manager panel and the site crash. If you later delete the cache folder, then everything works.

That is, as I understand it, MODX is trying to read the cache in the new format, but in the cache folder it is still in the old format.

Server on Ubuntu.

[sergant210]

@JoshuaLuckers I really don't understand why it's needed. PHP array is a natural format. It's clear and fast (thanks Opcache), no bugs and no additional manipulation.

MODX 2.7.3
PHP 7.3
Ubuntu 16.04
MySql 5.7.

Video (in Russian) that demonstrates this bug.

[opengeek]

You need to set the cache_format in the config_options array in the config file, as well as remove the existing cache in order to successfully make this change. It is complicated, but it does not need to be removed. Perhaps it needs an obvious warning.

[sergant210]

@opengeek I mean it. Remove this setting only from UI to avoid unexpected behavior. For the same reason the "cache_system_settings" setting was removed in MODX 2.7.0.

[Ruslan-Aleev]

By the way, even if you clean the cache folder, then after some time the manager panel and site crashes. I thought that the setting works, but only after deleting the cache folder, but it turns out that the setting does not work at all.

[opengeek]

By the way, even if you clean the cache folder, then after some time the manager panel and site crashes. I thought that the setting works, but only after deleting the cache folder, but it turns out that the setting does not work at all.

Did you add the corresponding setting to config_options as I described? If not, then no, it won't work because system settings are loaded from cache, too.

[Ruslan-Aleev]

@opengeek I have not seen your comment about the array.
Now I tried with an array in the configuration file - everything works, you're right.

[Ruslan-Aleev]

But then why do we need this setting if it does not work without editing the configuration file?
If you change in the manager panel - the setting breaks both the site and the manager panel.

In a good way, we need to make the setting uneditable in the manager panel, but with a description of the fact that it can be overridden in the config file.

[opengeek]

As @sergant210 said, we should probably remove it from the manager and cover the feature completely in the documentation.

[Ibochkarev]

As @sergant210 said, we should probably remove it from the manager and cover the feature completely in the documentation.

This is the most logical decision.