Simplify path generation in config.core.php

[Ruslan-Aleev]

Feature request

Summary

After installing MODX, a config.core.php file is created in the folders: /, connectors/, core/ and manager/ with the paths of the server folders, for example in /:

<?php
/*
 * This file is managed by the installation process.  Any modifications to it may get overwritten.
 * Add customizations to the $config_options array in `core/config/config.inc.php`.
 *
 */
define('MODX_CORE_PATH', '/home/a/account/folder/public_html/core/');
define('MODX_CONFIG_KEY', 'config');

But why not use the __DIR__ and __FILE__ constants when generating these paths?

Then the config.core.php file in / would look like this:

<?php
/*
 * This file is managed by the installation process.  Any modifications to it may get overwritten.
 * Add customizations to the $config_options array in `core/config/config.inc.php`.
 *
 */
define('MODX_CORE_PATH', dirname(__FILE__) . '/core/');
define('MODX_CONFIG_KEY', 'config');

Why is it needed?

When you move a site to another server, there will be less editing and fewer possible bugs.

[opengeek]

This is because the paths (other than core itself in 3.x) are configurable in the advanced installation. So those are only correct if you use the standard default install. That said, this could be done if the install is standard, and not advanced.

[Ruslan-Aleev]

This could be done if the install is standard, and not advanced.

Yes, that would be useful.

This is because the paths (other than core itself in 3.x) are configurable in the advanced installation.

Has anyone tried installing MODX 3 through an advanced installation? There is a high probability that the advanced installation does not work :)

[opengeek]

Has anyone tried installing MODX 3 through an advanced installation? There is a high probability that the advanced installation does not work :)

Not yet—I haven't been posting those anywhere. That will be one of the last steps—to reconfigure the advanced and SDK builds based on all the changes. I imagine setup changes have not been taking that into account properly.

[dimasites]

Hi friends! I found it moment as add complexity when modx site changes hosting or deploy test version.
It can be small needless problem for many developers. because Standard installation, i think, much often we can meet in the wild web.

May be we can fix it, and revert to relative paths (as was in past, i remember), for standart installation?

In MODX as i see in 3.0.5-pl (updated fron 3.0.2), in config.core.php path also hardcoded. And while advanced installation does not supported, we can use relative path in all config.core.php , yes?