From d8394999d2628b6a11b9a3c6f5a317a392e3511b Mon Sep 17 00:00:00 2001 From: Thomas Jakobi Date: Mon, 3 Mar 2025 11:33:03 +0100 Subject: [PATCH 1/4] Fix incorrect DATETIME value: '0000-00-00 00:00:00' --- core/src/Revolution/Processors/Workspace/Packages/Purge.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/Revolution/Processors/Workspace/Packages/Purge.php b/core/src/Revolution/Processors/Workspace/Packages/Purge.php index 501e2f203df..1cc59e51041 100644 --- a/core/src/Revolution/Processors/Workspace/Packages/Purge.php +++ b/core/src/Revolution/Processors/Workspace/Packages/Purge.php @@ -96,7 +96,7 @@ public function process() $c = $this->modx->newQuery(modTransportPackage::class, [ 'package_name' => $package->get('package_name'), ]); - $c->where(['installed:!=' => '0000-00-00 00:00:00']); + $c->where(array('installed:!=' => 0, 'installed:IS NOT' => NULL)); $c->sortby('installed', 'desc'); $c->limit(1000, 1); $purgedPackages = $this->modx->getIterator(modTransportPackage::class, $c); From b9b533bbe850a7727357822caafe3de29b699527 Mon Sep 17 00:00:00 2001 From: Thomas Jakobi Date: Mon, 3 Mar 2025 11:40:15 +0100 Subject: [PATCH 2/4] Remove the equal zero check --- core/src/Revolution/Processors/Workspace/Packages/Purge.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/Revolution/Processors/Workspace/Packages/Purge.php b/core/src/Revolution/Processors/Workspace/Packages/Purge.php index 1cc59e51041..ca573c46cf3 100644 --- a/core/src/Revolution/Processors/Workspace/Packages/Purge.php +++ b/core/src/Revolution/Processors/Workspace/Packages/Purge.php @@ -96,7 +96,7 @@ public function process() $c = $this->modx->newQuery(modTransportPackage::class, [ 'package_name' => $package->get('package_name'), ]); - $c->where(array('installed:!=' => 0, 'installed:IS NOT' => NULL)); + $c->where(array('installed:IS NOT' => NULL)); $c->sortby('installed', 'desc'); $c->limit(1000, 1); $purgedPackages = $this->modx->getIterator(modTransportPackage::class, $c); From e0852b20068a7400caf18931f4f5c7996711a3c0 Mon Sep 17 00:00:00 2001 From: Thomas Jakobi Date: Mon, 3 Mar 2025 11:41:20 +0100 Subject: [PATCH 3/4] Remove traditional array syntax --- core/src/Revolution/Processors/Workspace/Packages/Purge.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/Revolution/Processors/Workspace/Packages/Purge.php b/core/src/Revolution/Processors/Workspace/Packages/Purge.php index ca573c46cf3..8393f1be154 100644 --- a/core/src/Revolution/Processors/Workspace/Packages/Purge.php +++ b/core/src/Revolution/Processors/Workspace/Packages/Purge.php @@ -96,7 +96,7 @@ public function process() $c = $this->modx->newQuery(modTransportPackage::class, [ 'package_name' => $package->get('package_name'), ]); - $c->where(array('installed:IS NOT' => NULL)); + $c->where(['installed:IS NOT' => NULL]); $c->sortby('installed', 'desc'); $c->limit(1000, 1); $purgedPackages = $this->modx->getIterator(modTransportPackage::class, $c); From b678c5a4e6204d19432bb393103c8a7a6ec2ba82 Mon Sep 17 00:00:00 2001 From: Thomas Jakobi Date: Sun, 16 Mar 2025 14:33:20 +0100 Subject: [PATCH 4/4] Code quality fix --- core/src/Revolution/Processors/Workspace/Packages/Purge.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/Revolution/Processors/Workspace/Packages/Purge.php b/core/src/Revolution/Processors/Workspace/Packages/Purge.php index 8393f1be154..02d3ca4159b 100644 --- a/core/src/Revolution/Processors/Workspace/Packages/Purge.php +++ b/core/src/Revolution/Processors/Workspace/Packages/Purge.php @@ -96,7 +96,7 @@ public function process() $c = $this->modx->newQuery(modTransportPackage::class, [ 'package_name' => $package->get('package_name'), ]); - $c->where(['installed:IS NOT' => NULL]); + $c->where(['installed:IS NOT' => null]); $c->sortby('installed', 'desc'); $c->limit(1000, 1); $purgedPackages = $this->modx->getIterator(modTransportPackage::class, $c);