-
Notifications
You must be signed in to change notification settings - Fork 14
Open
Description
Hi!
Congrats for thor! Learned about it from HackerNews, and was surprised by the quality of the code! 👏
I think a .dockerignore file could be helpful, to avoid including unnecessary files in the build context.
Refs:
- https://codefresh.io/blog/not-ignore-dockerignore-2/
- https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#build-an-image-using-a-dockerfile-from-stdin-without-sending-build-context
I tried to quickly run thor using the Docker image, but stopped it when the last layer started downloading 1.3 GB 😅 Will leave it for when I'm connected to $work's network to save my bandwidth.
Cheers
Bruno
Metadata
Metadata
Assignees
Labels
No labels