Commit c2a101b
abacus_fixer
refactor(source_cell): fold KVectorUtils shim back into K_Vectors members
The KVectorUtils free functions were a migration-period compatibility
shim (2026-08-14); with all call sites now migrated, the shim only
added a second calling convention and two friend declarations.
- Move the real logic into K_Vectors members, line-by-line unchanged:
set_after_vc (public, was KVectorUtils::set_after_vc) and mpi_k
(private, __MPI-guarded, was KVectorUtils::kvec_mpi_k)
- Delete the four 1-line forwarders, of which kvec_d2c/kvec_c2d had no
callers left, and delete k_vector_utils.h/.cpp entirely
- Mechanical call-site updates: klist.cpp internal calls go straight
to the members, esolver_fp.cpp uses kv.set_after_vc(), tests use
kv-> methods (kvec_ibz_kpoint -> reduce_by_symmetry with the member
parameter order), 12 test CMakeLists.txt and Makefile.Objects drop
the k_vector_utils.cpp registration
- Drop the two K_Vectors friend declarations; update two comments that
referenced KVectorUtils::ibz_kpoint
Global dependency budget: k_vector_utils.cpp contributed 12 GlobalV
touches; the logic now lives inside the class that already carries the
k-list globals, so the PR-level count decreases.
Verified: make -j 30 (100%, incl. external module test targets); ctest
MODULE_CELL_{klist,reciprocal_grid,qlist}_test and klist_test_para1/
para4 5/5 passed (MPI path covers the moved mpi_k); grep confirms no
KVectorUtils references remain outside the two historical notes in
reciprocal_grid.h/.cpp.1 parent be4a82b commit c2a101b
23 files changed
Lines changed: 228 additions & 413 deletions
File tree
- source
- source_cell
- module_symmetry
- test
- source_esolver
- source_estate
- module_dm/test
- test
- source_hsolver/test
- source_io
- test_serial
- test
- source_lcao
- module_deepks/test
- module_deltaspin/test
- module_ri/module_exx_symmetry
- test
- source_pw/module_stodft/test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | | - | |
215 | 214 | | |
216 | 215 | | |
217 | 216 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | 36 | | |
38 | 37 | | |
39 | 38 | | |
| |||
This file was deleted.
This file was deleted.
0 commit comments