[v4.0.0] - Multiple ASS into a file delete previous fonts store

[BlackstormFirst]

Hello,

Actually if you have multiple ASS files into a MKV, each ass is correctly read, fonts are collected, but only the last ass fonts are stored.

It's like the fonts are stored after each ass but clean with the next one, and are not fully collected and stored at the end of the process.

Using this cmd:
fontcollector -ass-mkv --collect-draw-fonts -mkv "$fullpath" -d

[moi15moi]

Please, give a full example by sharing the .ass and the font. In your example, use the flag --additional-fonts so I can easily reproduce it.

If you don't have a small mkv, you can use this one test_video.zip

[BlackstormFirst]

I used your test_video.
I added 7 ass files with at least one file with another font.
i used fontcollector with the '-d' parameter and got 3 fonts:

So, after multiple tests on some files, i am not able to reproduice the context of the issue... but on my test i found, that you can :

• add all fonts from mkv scan, but if several fonts already exist into the mkv, it duplicate them (or if you run the same command on the same file).
• if you use the '-d', as it's said, all existing fonts are deleted before the scan and all fonts found are added.

but, how can i do to just "update" the missing fonts without duplicate the existant one, and without remove the existant (some time i have external subs witch use theirs own fonts and was previously added).

Thanks in advance.

[moi15moi]

but, how can i do to just "update" the missing fonts without duplicate the existant one, and without remove the existant (some time i have external subs witch use theirs own fonts and was previously added).

This is currently not possible.

I tried to implement it in this commit (c9187b9), but as noted in the commit description, there are many problem that I don't know how to handle them. The third one could be fixed, but the first two aren't simple.

To fix the issue noted in my commit, it would need a major refactoring that I am not willing to do since I don't believe this is a useful feature.

[BlackstormFirst]

A feature to update may be aprecated, but it depend of the context indeed.

It should be great if we can have a means to keep the existing fonts, because sometime you can have the case where fonts are into the mkv but do not exist on your system.
Using the "-d" parameter clean all the content and the basic command complete it but it can create duplicates.

To remove duplicates, i can use mkvfontvalidator, but it use another binary and a complete process...