Bugs in TimeTerm

[igorcadelima]

Hi, @jomifred

I believe that there are a couple of bugs in the TimeTerm class:

• The time calculation using years is wrong as it considers years as having 356 days, which is never true
• Assuming that the point above was a typing mistake when you intended to type 365, that'd still be wrong as it doesn't consider leap years
• The calculations don't consider daylight savings

Joda-Time is a Java library you might want to take a look at as it allows you to perform time calculations seamlessly.

Cheers,
Igor.

[jomifred]

Hi, thanks Igor for the suggestion! I'd prefer to use the new API for time in java 8, to avoid new dependencies in the project. Wouldn't you take a look on that and propose a PR :-) ?

[igorcadelima]

I just took a quick look at the new Java 8 API for time and it's indeed a better option! I'll let you know when I start working on this issue.

[jomifred]

Thanks a lot. Notice that (AFAIK) the date format (in Gregorian Calendar) is used just for presentation/annotations. I guess it is not used for something really important in the engine.