Dropping legacy support for metadata based actions (#294)

* improve action extraction

* wip

Author: sandervanhooft

src/FirstPayment/FirstPaymentHandler.php

@@ -96,19 +96,19 @@ protected function extractOwner()
     protected function extractActions()
     {
         $payment = Cashier::$paymentModel::findByPaymentId($this->molliePayment->id);
-
-        if (isset($payment) && ! is_null($payment->first_payment_actions)) {
-            $actions = $payment->first_payment_actions;
-        } else {
-            $actions = $this->molliePayment->metadata->actions;
-        }
-
-        return collect($actions)->map(function ($actionMeta) {
-            return $actionMeta->handler::createFromPayload(
-                object_to_array_recursive($actionMeta),
-                $this->owner
-            );
-        });
+        $actions = $payment?->first_payment_actions;
+
+        /*
+         * For legacy reasons, the first_payment_actions value is (de)serialized on the Payment model as an object
+         * instead of an array. This is handled by `collect()` just fine.
+         */
+        return collect($actions)
+            ->map(function ($action) {
+                return $action->handler::createFromPayload(
+                    object_to_array_recursive($action),
+                    $this->owner
+                );
+            });
     }
 
     /**

src/Payment.php

@@ -24,7 +24,7 @@
  * @property int amount
  * @property int amount_refunded
  * @property int amount_charged_back
- * @property string first_payment_actions
+ * @property object first_payment_actions // An object for legacy reasons
  * @property string mollie_mandate_id
  * @property \Laravel\Cashier\Order\Order order
  *