Upgrade to mollie/laravel-mollie v4 (#316)

* Upgrade to mollie/laravel-mollie v4

- Update mollie/laravel-mollie constraint from ^3.0 to ^4.0
- Remove direct mollie/mollie-api-php dependency (now transitive)
- Update Mollie SDK constant references (drop STATUS_/SEQUENCETYPE_ prefixes)
- Handle RefundCollection and ApiException constructor changes
- Migrate PHPUnit annotations to PHP 8 attributes (#[Test], #[Group])
- Require PHP 8.2+ and Laravel 11+
- Add CI resolve and prefer-lowest jobs

* Fix malformed docblocks in ManageSubscriptionTest and ConfigPlanRepositoryTest

* Bump orchestra/testbench minimum to ^9.6 for prefer-lowest compatibility

Testbench v9.0.x resolves to early Laravel 11 versions that lack the
$latestResponse static property, causing errors with --prefer-lowest.

Author: sandervanhooft

.github/workflows/tests.yaml

@@ -7,25 +7,46 @@ on:
         - cron: '0 0 * * *'
 
 jobs:
-    tests:
+    resolve:
+        name: Resolve P${{ matrix.php }} - L${{ matrix.laravel }}
+        runs-on: ubuntu-latest
+        strategy:
+            fail-fast: false
+            matrix:
+                php: [ 8.4, 8.3, 8.2 ]
+                laravel: [ 13.*, 12.*, 11.* ]
+                exclude:
+                    - php: 8.2
+                      laravel: 13.*
+        steps:
+            - name: Checkout code
+              uses: actions/checkout@v4
 
+            - name: Setup PHP
+              uses: shivammathur/setup-php@v2
+              with:
+                  php-version: ${{ matrix.php }}
+                  extensions: curl, dom, intl, json, libxml, mbstring, openssl, zip
+                  tools: composer:v2
+
+            - name: Check dependency resolution
+              run: |
+                  composer require illuminate/support:${{ matrix.laravel }} --no-update --no-interaction
+                  composer update --prefer-stable --prefer-dist --no-interaction --no-progress --dry-run
+
+    tests:
+        name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.dependency-version }}
         runs-on: ubuntu-latest
+        needs: resolve
         strategy:
             fail-fast: true
             matrix:
-                os: [ ubuntu-latest ]
-                php: [ 8.4, 8.3, 8.2, 8.1 ]
-                laravel: [ 13.*, 12.*, 11.*, 10.* ]
+                php: [ 8.4, 8.3, 8.2 ]
+                laravel: [ 13.*, 12.*, 11.* ]
                 dependency-version: [ prefer-stable ]
                 exclude:
-                    - php: 8.1
-                      laravel: 13.*
                     - php: 8.2
                       laravel: 13.*
-                    - php: 8.1
-                      laravel: 12.*
-
-        name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.dependency-version }} - ${{ matrix.os }}
 
         steps:
             - name: Checkout code
@@ -41,7 +62,30 @@ jobs:
 
             - name: Install dependencies
               run: |
+                  composer require illuminate/support:${{ matrix.laravel }} --no-update --no-interaction
                   composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-progress
 
             - name: Execute tests
               run: vendor/bin/phpunit --coverage-text
+
+    prefer-lowest:
+        name: Prefer lowest (P8.2)
+        runs-on: ubuntu-latest
+        steps:
+            - name: Checkout code
+              uses: actions/checkout@v4
+
+            - name: Setup PHP
+              uses: shivammathur/setup-php@v2
+              with:
+                  php-version: 8.2
+                  extensions: curl, dom, intl, json, libxml, mbstring, openssl, zip
+                  tools: composer:v2
+                  coverage: xdebug
+
+            - name: Install lowest dependencies
+              run: |
+                  composer update --prefer-lowest --prefer-stable --prefer-dist --no-interaction --no-progress
+
+            - name: Execute tests
+              run: vendor/bin/phpunit --coverage-text

composer.json

@@ -30,22 +30,21 @@
     }
   ],
   "require": {
-    "php": "^8.1",
+    "php": "^8.2",
     "ext-json": "*",
     "ext-intl": "*",
     "dompdf/dompdf": "^2.0|^3.0",
-    "illuminate/database": "^10|^11|^12|^13",
-    "illuminate/support": "^10|^11|^12|^13",
-    "mollie/laravel-mollie": "^3.0",
-    "mollie/mollie-api-php": "^2.76",
+    "illuminate/database": "^11|^12|^13",
+    "illuminate/support": "^11|^12|^13",
+    "mollie/laravel-mollie": "^4.0",
     "moneyphp/money": "^4.1",
     "nesbot/carbon": "^2.72|^3.0"
   },
   "require-dev": {
     "guzzlehttp/guzzle": "^7.0",
     "mockery/mockery": "^1.4",
-    "orchestra/testbench": "^8.0|^9.0|^10.0|^11.0",
-    "phpunit/phpunit": "^10.0|^11.5"
+    "orchestra/testbench": "^9.6|^10.0|^11.0",
+    "phpunit/phpunit": "^10.5|^11.5|^12.0|^13.0"
   },
   "autoload": {
     "files": [

src/FirstPayment/FirstPaymentBuilder.php

@@ -102,7 +102,7 @@ public function inOrderTo(array $actions = [])
     public function getMolliePayload()
     {
         return array_filter(array_merge([
-            'sequenceType' => SequenceType::SEQUENCETYPE_FIRST,
+            'sequenceType' => SequenceType::FIRST,
             'method' => $this->method,
             'customerId' => $this->owner->asMollieCustomer()->id,
             'locale' => Cashier::getLocale($this->owner),

src/Http/Controllers/AftercareWebhookController.php

@@ -78,10 +78,10 @@ protected function handleRefunds(Order $order, MolliePayment $molliePayment)
             $mollieRefund = $this->extractMatchingMollieRefundForLocalRefund($localRefund, $mollieRefunds);
 
             if ($mollieRefund) {
-                if ($mollieRefund->isTransferred() && $localRefund->mollie_refund_status !== RefundStatus::STATUS_REFUNDED) {
+                if ($mollieRefund->isTransferred() && $localRefund->mollie_refund_status !== RefundStatus::REFUNDED) {
                     $localRefund->handleProcessed();
                     $paymentAmountRefundedHasChanged = true;
-                } elseif ($mollieRefund->isFailed() && $localRefund->mollie_refund_status !== RefundStatus::STATUS_FAILED) {
+                } elseif ($mollieRefund->isFailed() && $localRefund->mollie_refund_status !== RefundStatus::FAILED) {
                     $localRefund->handleFailed();
                     $paymentAmountRefundedHasChanged = true;
                 }

src/Http/Controllers/WebhookController.php

@@ -26,7 +26,7 @@ public function handleWebhook(Request $request)
 
             if ($order && $order->mollie_payment_status !== $payment->status) {
                 switch ($payment->status) {
-                    case PaymentStatus::STATUS_PAID:
+                    case PaymentStatus::PAID:
                         $order->handlePaymentPaid($payment);
                         $payment->webhookUrl = route('webhooks.mollie.aftercare');
 
@@ -35,7 +35,7 @@ public function handleWebhook(Request $request)
                         $updateMolliePayment->execute($payment);
 
                         break;
-                    case PaymentStatus::STATUS_FAILED:
+                    case PaymentStatus::FAILED:
                         $order->handlePaymentFailed($payment);
 
                         break;

src/MandatedPayment/MandatedPaymentBuilder.php

@@ -67,7 +67,7 @@ public function getPayload(array $overrides = [])
         $overrides = array_merge($this->overrides, $overrides);
 
         return array_filter(array_merge([
-            'sequenceType' => SequenceType::SEQUENCETYPE_RECURRING,
+            'sequenceType' => SequenceType::RECURRING,
             'mandateId' => $this->owner->mollieMandateId(),
             'customerId' => $this->owner->mollieCustomerId(),
             'locale' => Cashier::getLocale($this->owner),

src/Order/Order.php

@@ -396,7 +396,7 @@ public function scopePaymentStatus($query, $status)
     public function scopePaid($query)
     {
         return $this
-            ->scopePaymentStatus($query, PaymentStatus::STATUS_PAID)
+            ->scopePaymentStatus($query, PaymentStatus::PAID)
             ->orWhere('total_due', '=', 0);
     }
 

src/Payment.php

@@ -137,7 +137,7 @@ public static function findByMolliePaymentOrCreate(MolliePayment $molliePayment,
 
         $newPayment = static::createFromMolliePayment($molliePayment, $owner, $actions);
 
-        if ($newPayment->mollie_payment_status === PaymentStatus::STATUS_PAID) {
+        if ($newPayment->mollie_payment_status === PaymentStatus::PAID) {
             $molliePayment->webhookUrl = route('webhooks.mollie.aftercare');
 
             /** @var UpdateMolliePayment $updateMolliePayment */

src/Refunds/Refund.php

@@ -58,7 +58,7 @@ public function newCollection(array $models = [])
      */
     public function scopeWhereUnprocessed(Builder $query)
     {
-        return $query->where('mollie_refund_status', RefundStatus::STATUS_PENDING);
+        return $query->where('mollie_refund_status', RefundStatus::PENDING);
     }
 
     public function items(): HasMany
@@ -85,7 +85,7 @@ public function handleProcessed(): self
             $order = Cashier::$orderModel::createProcessedFromItems($orderItems);
 
             $this->order_id = $order->id;
-            $this->mollie_refund_status = RefundStatus::STATUS_REFUNDED;
+            $this->mollie_refund_status = RefundStatus::REFUNDED;
 
             $this->save();
 
@@ -111,7 +111,7 @@ public function handleFailed(): self
         $refundItems = $this->items;
 
         DB::transaction(function () use ($refundItems) {
-            $this->mollie_refund_status = RefundStatus::STATUS_FAILED;
+            $this->mollie_refund_status = RefundStatus::FAILED;
 
             $this->save();
 

src/Refunds/RefundBuilder.php

@@ -79,7 +79,7 @@ public function addItemsFromOrderItemCollection(OrderItemCollection $orderItems,
     protected static function guardOrderIsPaid(Order $order)
     {
         throw_unless(
-            $order->mollie_payment_status === PaymentStatus::STATUS_PAID,
+            $order->mollie_payment_status === PaymentStatus::PAID,
             new LogicException('Only paid orders can be refunded')
         );
     }