Skip to content

Commit 424b99d

Browse files
authored
fix: PHP 8.4 deprecation - use explicit nullable type in downloadInvoice()
## Summary This PR fixes a PHP 8.4 deprecation warning by using explicit nullable type declaration. ## Problem PHP 8.4 deprecated implicit nullable parameter declarations. The following warning is triggered:
1 parent 85def4e commit 424b99d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/Billable.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ public function invoices()
423423
* @param \Dompdf\Options $options
424424
* @return \Symfony\Component\HttpFoundation\Response
425425
*/
426-
public function downloadInvoice($orderId, $data = [], $view = Invoice::DEFAULT_VIEW, Options $options = null)
426+
public function downloadInvoice($orderId, $data = [], $view = Invoice::DEFAULT_VIEW, ?Options $options = null)
427427
{
428428
/** @var Order $order */
429429
$order = $this->orders()->where('id', $orderId)->firstOrFail();

0 commit comments

Comments
 (0)