Skip to content

Go examples should have caught NewClient issue #401

Open
@bruuuuuuuce

Description

When trying to upgrade grpc-go to include our changes to add the NewClient method, we accidentally broke the go sdk. The issue stems from how we used the replace directive to point to our forked version of grpc-go.

replace google.golang.org/grpc => github.com/momentohq/grpc-go v1.61.0-dev.0.20240306220430-6ad501388d03

When a customer would install our sdk, they would see an error saying NewClient method does not exist. This should have been caught by our examples

github.com/momentohq/client-sdk-go v1.19.0

Which we pointing to a version of the sdk that included this replace change, but the examples passed. We should figure out why they were passing, and fix it so they are able to validate our sdk installs correctly. The change was released in version 1.17.0

image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bug 🐞Something isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions