Merge pull request #19 from momotaro98/feature/security-update

Feature/security update

Author: momotaro98

README.md

@@ -4,8 +4,6 @@ Sidebar Extension for Markdown on Gist
 
 ![page-contents-sidebar_demo](https://github.com/momotaro98/my-project-images/blob/master/page-contents-sidebar/demo.gif)
 
-
-
 ## Features
 
 * Display header title of Markdown file
@@ -21,19 +19,19 @@ Scheduled to support other sites such as GitHub and Confluence.
 
 ## Development
 
-### npm install
+### Start development
 
 ```
 $ cd page-contents-sidebar
 $ npm install
 ```
 
-### Build app
+### Build, run, and watch app
 
-Modify `src` files and run gulp command
+Modify `src` files and run and watch app by building with gulp
 
 ```
-$ gulp
+$ npm start
 ```
 
 ### Inspect app
@@ -43,7 +41,7 @@ Open `tmp/app` directory as extension in Chrome browser, [chrome://extensions/](
 ## Deployment app to Chrome Extension
 
 0. Update `version` of package.json
-0. Run `gulp` and see `tmp/app`
+0. Run `npm run-script build` or `gulp build` and check `tmp/app` TODO: Use `npm dist` with zip the dir
 0. Create a zip file of `tmp/app`
 0. Go to [Chrome Ex Dashboard](https://chrome.google.com/webstore/developer/dashboard) and upload the zip file
 0. Push update to master and create release and tag

gulpfile.js

@@ -4,17 +4,11 @@ const map = require('map-stream');
 const $ = require('gulp-load-plugins')();
 const version = require('./package.json').version;
 
-// Tasks
 gulp.task('clean', () => {
-  return pipe('./tmp', $.clean());
-});
-
-gulp.task('build', (cb) => {
-  $.runSequence('clean', 'style', 'template', 'js', 'devdist', cb);
-});
-
-gulp.task('default', ['build'], () => {
-  gulp.watch(['./libs/**/*', './src/**/*'], ['default']);
+  return pipe(
+    './tmp',
+    $.clean()
+  );
 });
 
 gulp.task('style', () => {
@@ -38,7 +32,7 @@ gulp.task('template', () => {
   );
 });
 
-gulp.task('js', ['template'], () => {
+gulp.task('js', gulp.series('template', () => {
   const src = [
     './tmp/template.js',
     './src/constants.js',
@@ -56,16 +50,29 @@ gulp.task('js', ['template'], () => {
     $.concat('mdisviewer.js'),
     './tmp'
   );
-});
+}));
 
-gulp.task('devdist', ['js'], () => {
-  return merge(
+gulp.task('devdist', gulp.series('js', (cb) => {
+   merge(
     pipe('./icons/**/*', './tmp/app/icons'),
     pipe(['./libs/**/*', './tmp/mdisviewer.*'], './tmp/app/'),
     pipe('./src/config/background.js', './tmp/app/'),
     pipe('./src/config/manifest.json', $.replace('$VERSION', version), './tmp/app/')
   );
-});
+  cb(); // Need this callback after Gulp4 because `return merge()` doesn't returns stream
+}));
+
+gulp.task('build', gulp.series(
+  'clean',
+  'style',
+  'template',
+  'js',
+  'devdist'
+));
+
+gulp.task('default', gulp.series('build', () => {
+  gulp.watch(['./libs/**/*', './src/**/*'], gulp.task('default'));
+}));
 
 // Helpers
 function pipe(src, ...transforms) {
@@ -90,7 +97,7 @@ function html2js(template) {
     const body = template.replace('$$', escaped);
 
     file.path = path;
-    file.contents = new Buffer(body);
+    file.contents = Buffer.from(body);
     cb(null, file);
   }
 }