Fix weird double shutdown bug

While preapring for app freeze, we reset _shutdownPending to NO.
That deactivated the failsafe used to ignore idle states on disconnected
accounts and triggered a second shutdown.
(But since the app suspension was already triggered (the bg task was
terminated), the double shutdown got delayed to next app foreground.)
The second shutdown tried to flush the log, but the logging queue was
already suspended, so the flushing blocked the main thread indefinitely
leading to the iOS watchdog killing the app.

This was not visible in any logfiles, because of the suspended logging
queue, but our new udp logger force send made it visible.

Author: tmolitor-stud-tu

Monal/Classes/MonalAppDelegate.m

@@ -59,7 +59,7 @@ @interface MonalAppDelegate()
     MLContact* _contactToOpen;
     monal_id_block_t _completionToCall;
     BOOL _shutdownPending;
-    BOOL _wasFreezed;
+    BOOL _wasFrozen;
 }
 @end
 
@@ -323,7 +323,7 @@ -(id) init
     _wakeupCompletions = [NSMutableDictionary new];
     DDLogVerbose(@"Setting _shutdownPending to NO...");
     _shutdownPending = NO;
-    _wasFreezed = NO;
+    _wasFrozen = NO;
 
     //[self runParserTests];
     //[self runSDPTests];
@@ -1134,11 +1134,7 @@ -(void) prepareForFreeze:(NSNotification*) notification
     for(xmpp* account in [MLXMPPManager sharedInstance].connectedXMPP)
         [account freeze];
     [MLProcessLock unlock];
-    _wasFreezed = YES;
-    @synchronized(self) {
-        DDLogVerbose(@"Setting _shutdownPending to NO...");
-        _shutdownPending = NO;
-    }
+    _wasFrozen = YES;
 }
 
 -(void) applicationWillEnterForeground:(UIApplication*) application
@@ -1156,14 +1152,14 @@ -(void) applicationWillEnterForeground:(UIApplication*) application
 
     //only show loading HUD if we really got freezed before
     MBProgressHUD* loadingHUD;
-    if(_wasFreezed)
+    if(_wasFrozen)
     {
         loadingHUD = [MBProgressHUD showHUDAddedTo:[self getTopViewController].view animated:YES];
         loadingHUD.label.text = NSLocalizedString(@"Refreshing...", @"");
         loadingHUD.mode = MBProgressHUDModeIndeterminate;
         loadingHUD.removeFromSuperViewOnHide = YES;
 
-        _wasFreezed = NO;
+        _wasFrozen = NO;
     }
 
     dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{