fix: reduce audit condition event noise

Author: MaxRink

controllers/mondooauditconfig_controller.go

@@ -232,6 +232,7 @@ func (r *MondooAuditConfigReconciler) Reconcile(ctx context.Context, req ctrl.Re
 
 		deferFuncErr = mondoo.UpdateMondooAuditStatus(deferCtx, r.Client, mondooAuditConfigCopy, mondooAuditConfig, log)
 		if deferFuncErr == nil {
+			// mondooAuditConfigCopy holds the original conditions; mondooAuditConfig was updated in-place.
 			r.recordConditionEvents(mondooAuditConfig, mondooAuditConfigCopy.Status.Conditions, mondooAuditConfig.Status.Conditions)
 		}
 		// do not overwrite errors which happened before the defered function is called
@@ -378,7 +379,12 @@ func (r *MondooAuditConfigReconciler) recordConditionEvents(
 	}
 
 	for _, condition := range newConditions {
-		if oldCondition, ok := oldByType[condition.Type]; ok && conditionEventFieldsEqual(oldCondition, condition) {
+		oldCondition, ok := oldByType[condition.Type]
+		if ok {
+			if conditionEventFieldsEqual(oldCondition, condition) {
+				continue
+			}
+		} else if condition.Status == corev1.ConditionFalse {
 			continue
 		}
 

controllers/mondooauditconfig_controller_test.go

@@ -572,6 +572,12 @@ func TestRecordConditionEvents(t *testing.T) {
 			Reason:  "KubernetesResourcesScanningAvailable",
 			Message: "Kubernetes Resources Scanning is available",
 		},
+		{
+			Type:    v1alpha2.NodeScanningDegraded,
+			Status:  corev1.ConditionTrue,
+			Reason:  "NodeScanningUnavailable",
+			Message: "Node Scanning is unavailable",
+		},
 	}
 	newConditions := []v1alpha2.MondooAuditConfigCondition{
 		{
@@ -595,6 +601,25 @@ func TestRecordConditionEvents(t *testing.T) {
 	assertNoRecordedEvent(t, recorder)
 }
 
+func TestRecordConditionEventsSkipsInitialHealthyConditions(t *testing.T) {
+	config := testMondooAuditConfig()
+	recorder := record.NewFakeRecorder(1)
+	reconciler := &MondooAuditConfigReconciler{EventRecorder: recorder}
+
+	newConditions := []v1alpha2.MondooAuditConfigCondition{
+		{
+			Type:    v1alpha2.K8sContainerImageScanningDegraded,
+			Status:  corev1.ConditionFalse,
+			Reason:  "KubernetesContainerImageScanningAvailable",
+			Message: "Kubernetes Container Image Scanning is available",
+		},
+	}
+
+	reconciler.recordConditionEvents(config, nil, newConditions)
+
+	assertNoRecordedEvent(t, recorder)
+}
+
 func TestRecordConditionEventsSkipsUnchangedConditions(t *testing.T) {
 	config := testMondooAuditConfig()
 	recorder := record.NewFakeRecorder(1)