🐛 Add ImagePullSecrets to UpdateCronJobFields, UpdateDeploymentFields, and UpdateDaemonSetFields

slntopp · slntopp · commit bf239b15208d · 2026-03-12T18:46:50.000+01:00
diff --git a/pkg/utils/k8s/update_fields.go b/pkg/utils/k8s/update_fields.go
@@ -37,6 +37,7 @@ func UpdateCronJobFields(obj, desired *batchv1.CronJob) {
 	ps.InitContainers = dps.InitContainers
 	ps.Containers = dps.Containers
 	ps.Volumes = dps.Volumes
+	ps.ImagePullSecrets = dps.ImagePullSecrets
 }
 
 // UpdateDeploymentFields copies managed fields from desired to obj,
@@ -54,6 +55,7 @@ func UpdateDeploymentFields(obj, desired *appsv1.Deployment) {
 	ps.ServiceAccountName = dps.ServiceAccountName
 	ps.Containers = dps.Containers
 	ps.Volumes = dps.Volumes
+	ps.ImagePullSecrets = dps.ImagePullSecrets
 }
 
 // UpdateDaemonSetFields copies managed fields from desired to obj,
@@ -73,4 +75,5 @@ func UpdateDaemonSetFields(obj, desired *appsv1.DaemonSet) {
 	ps.Tolerations = dps.Tolerations
 	ps.Containers = dps.Containers
 	ps.Volumes = dps.Volumes
+	ps.ImagePullSecrets = dps.ImagePullSecrets
 }

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ func UpdateCronJobFields(obj, desired *batchv1.CronJob) {`
`37`	`37`	`ps.InitContainers = dps.InitContainers`
`38`	`38`	`ps.Containers = dps.Containers`
`39`	`39`	`ps.Volumes = dps.Volumes`
	`40`	`+ ps.ImagePullSecrets = dps.ImagePullSecrets`
`40`	`41`	`}`
`41`	`42`
`42`	`43`	`// UpdateDeploymentFields copies managed fields from desired to obj,`
`@@ -54,6 +55,7 @@ func UpdateDeploymentFields(obj, desired *appsv1.Deployment) {`
`54`	`55`	`ps.ServiceAccountName = dps.ServiceAccountName`
`55`	`56`	`ps.Containers = dps.Containers`
`56`	`57`	`ps.Volumes = dps.Volumes`
	`58`	`+ ps.ImagePullSecrets = dps.ImagePullSecrets`
`57`	`59`	`}`
`58`	`60`
`59`	`61`	`// UpdateDaemonSetFields copies managed fields from desired to obj,`
`@@ -73,4 +75,5 @@ func UpdateDaemonSetFields(obj, desired *appsv1.DaemonSet) {`
`73`	`75`	`ps.Tolerations = dps.Tolerations`
`74`	`76`	`ps.Containers = dps.Containers`
`75`	`77`	`ps.Volumes = dps.Volumes`
	`78`	`+ ps.ImagePullSecrets = dps.ImagePullSecrets`
`76`	`79`	`}`