Rename gcpLevelEncoder to severityLevelEncoder for cloud-agnostic naming

Update comments to reference all major cloud providers (GKE, AKS, EKS)
instead of just GCP/GKE.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: chris-rock

pkg/utils/logger/logger.go

@@ -9,9 +9,9 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-// gcpLevelEncoder encodes log levels to Google Cloud Logging severity names.
-// GCP expects "WARNING" instead of zap's "WARN", and maps DPANIC/PANIC/FATAL to CRITICAL.
-func gcpLevelEncoder(level zapcore.Level, enc zapcore.PrimitiveArrayEncoder) {
+// severityLevelEncoder encodes log levels to cloud-compatible severity names.
+// Uses "WARNING" instead of zap's "WARN", and maps DPANIC/PANIC/FATAL to CRITICAL.
+func severityLevelEncoder(level zapcore.Level, enc zapcore.PrimitiveArrayEncoder) {
 	switch level {
 	case zapcore.WarnLevel:
 		enc.AppendString("WARNING")
@@ -24,18 +24,18 @@ func gcpLevelEncoder(level zapcore.Level, enc zapcore.PrimitiveArrayEncoder) {
 
 func NewLogger() logr.Logger {
 	opts := zap.Options{
-		// Use production mode by default for JSON output (required for GKE log parsing).
+		// Use production mode for JSON output (enables structured logging in cloud environments).
 		// Can be overridden with --zap-devel flag for local development.
 		Development:     false,
 		StacktraceLevel: zapcore.DPanicLevel,
 		TimeEncoder:     zapcore.RFC3339TimeEncoder,
-		// Configure encoder for GCP/GKE compatibility:
-		// - Use "severity" instead of "level" for log level field
-		// - Use GCP-compatible level names (WARNING instead of WARN)
+		// Configure encoder for cloud logging compatibility:
+		// - Use "severity" field name (recognized by GKE, AKS, EKS log explorers)
+		// - Use standard severity names (WARNING instead of WARN, CRITICAL for fatal errors)
 		EncoderConfigOptions: []zap.EncoderConfigOption{
 			func(ec *zapcore.EncoderConfig) {
 				ec.LevelKey = "severity"
-				ec.EncodeLevel = gcpLevelEncoder
+				ec.EncodeLevel = severityLevelEncoder
 			},
 		},
 	}

pkg/utils/logger/logger_test.go

@@ -37,14 +37,14 @@ func (t *testEncoder) AppendUint16(uint16)         {}
 func (t *testEncoder) AppendUint8(uint8)           {}
 func (t *testEncoder) AppendUintptr(uintptr)       {}
 
-func TestGcpLevelEncoder(t *testing.T) {
+func TestSeverityLevelEncoder(t *testing.T) {
 	tests := []struct {
 		level    zapcore.Level
 		expected string
 	}{
 		{zapcore.DebugLevel, "DEBUG"},
 		{zapcore.InfoLevel, "INFO"},
-		{zapcore.WarnLevel, "WARNING"}, // GCP expects WARNING, not WARN
+		{zapcore.WarnLevel, "WARNING"}, // Cloud log explorers expect WARNING, not WARN
 		{zapcore.ErrorLevel, "ERROR"},
 		{zapcore.DPanicLevel, "CRITICAL"},
 		{zapcore.PanicLevel, "CRITICAL"},
@@ -54,7 +54,7 @@ func TestGcpLevelEncoder(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.level.String(), func(t *testing.T) {
 			enc := &testEncoder{}
-			gcpLevelEncoder(tt.level, enc)
+			severityLevelEncoder(tt.level, enc)
 			assert.Equal(t, tt.expected, enc.result)
 		})
 	}