Skip to content

v13 registry mirroring and proxying testing#1422

Merged
slntopp merged 4 commits intomainfrom
mik/v13-test-registry-mirroring-and-proxying
Mar 12, 2026
Merged

v13 registry mirroring and proxying testing#1422
slntopp merged 4 commits intomainfrom
mik/v13-test-registry-mirroring-and-proxying

Conversation

@slntopp
Copy link
Copy Markdown
Member

@slntopp slntopp commented Mar 12, 2026

No description provided.

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds e2e tests for registry mirroring/proxy and fixes ImagePullSecrets not being propagated on resource updates.

Comment thread tests/e2e/terraform/proxy.tf Outdated
Comment thread tests/e2e/terraform/proxy.tf
Comment thread tests/e2e/scripts/deploy-operator-mirroring.sh
Comment thread tests/e2e/terraform/terraform.example.tfvars Outdated
Comment thread pkg/utils/k8s/update_fields.go
@github-actions

This comment has been minimized.

@slntopp
Copy link
Copy Markdown
Member Author

slntopp commented Mar 12, 2026

Addressed all review comments:

  1. SSH firewall rule (proxy.tf:89): Removed public IP (access_config) and switched to IAP tunneling. SSH firewall now only allows GCP IAP range (35.235.240.0/20). Verify script updated to use --tunnel-through-iap.

  2. Precondition for enable_proxy_test (proxy.tf:9): Added lifecycle.precondition to enforce that enable_mirror_test must be true when enable_proxy_test is set.

  3. Trap single quotes (deploy-operator-mirroring.sh:51): Changed to single-quoted trap to defer variable expansion.

  4. Trailing newline (terraform.example.tfvars:11): Added trailing newline.

  5. Unit tests for update_fields.go: Added update_fields_test.go with tests for ImagePullSecrets propagation across all three update helpers (CronJob, Deployment, DaemonSet), plus a test verifying unmanaged fields are preserved.

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three previous findings have been addressed: Terraform validation added, trap quoting fixed, and unit tests added.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

Test Results

  7 files  ±0   44 suites  ±0   1h 42m 8s ⏱️ + 11m 12s
397 tests +4  393 ✅ ±0  0 💤 ±0  4 ❌ +4 
463 runs  +4  453 ✅ ±0  6 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit c22c386. ± Comparison against base commit 0568f1a.

♻️ This comment has been updated with latest results.

@slntopp slntopp merged commit 8783f67 into main Mar 12, 2026
42 of 44 checks passed
@slntopp slntopp deleted the mik/v13-test-registry-mirroring-and-proxying branch March 12, 2026 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants