resource creation to use constants for resource names

Author: florinutz

providers/aws/resources/aws_autoscaling.go

@@ -118,8 +118,8 @@ func initAwsAutoscalingGroup(runtime *plugin.Runtime, args map[string]*llx.RawDa
 		args["name"] = llx.StringDataPtr(group.AutoScalingGroupName)
 		args["region"] = llx.StringData(region)
 		args["tags"] = llx.MapData(autoscalingTagsToMap(group.Tags), types.String)
-		args["tagSpecifications"] = llx.ArrayData(tagSpecs, types.Resource("aws.autoscaling.group.tag"))
-		mqlGroup, err := CreateResource(runtime, "aws.autoscaling.group", args)
+		args["tagSpecifications"] = llx.ArrayData(tagSpecs, types.Resource(ResourceAwsAutoscalingGroupTag))
+		mqlGroup, err := CreateResource(runtime, ResourceAwsAutoscalingGroup, args)
 		if err != nil {
 			return args, nil, err
 		}
@@ -170,7 +170,7 @@ func (a *mqlAwsAutoscaling) getGroups(conn *connection.AwsConnection) []*jobpool
 						return nil, err
 					}
 
-					mqlGroup, err := CreateResource(a.MqlRuntime, "aws.autoscaling.group",
+					mqlGroup, err := CreateResource(a.MqlRuntime, ResourceAwsAutoscalingGroup,
 						map[string]*llx.RawData{
 							"arn":                     llx.StringData(groupArn),
 							"availabilityZones":       llx.ArrayData(availabilityZones, types.String),
@@ -189,7 +189,7 @@ func (a *mqlAwsAutoscaling) getGroups(conn *connection.AwsConnection) []*jobpool
 							"name":                    llx.StringDataPtr(group.AutoScalingGroupName),
 							"region":                  llx.StringData(region),
 							"tags":                    llx.MapData(autoscalingTagsToMap(group.Tags), types.String),
-							"tagSpecifications":       llx.ArrayData(tagSpecs, types.Resource("aws.autoscaling.group.tag")),
+							"tagSpecifications":       llx.ArrayData(tagSpecs, types.Resource(ResourceAwsAutoscalingGroupTag)),
 						})
 					if err != nil {
 						return nil, err
@@ -224,7 +224,7 @@ func createTagSpecifications(runtime *plugin.Runtime, tags []ec2types.TagDescrip
 		key := convert.ToValue(tag.Key)
 		tagId := fmt.Sprintf("%s/tag/%s", groupArn, key)
 
-		mqlTag, err := CreateResource(runtime, "aws.autoscaling.group.tag",
+		mqlTag, err := CreateResource(runtime, ResourceAwsAutoscalingGroupTag,
 			map[string]*llx.RawData{
 				"__id":              llx.StringData(tagId),
 				"key":               llx.StringData(key),

providers/aws/resources/aws_codedeploy.go

@@ -251,7 +251,7 @@ func (dg *mqlAwsCodedeployDeploymentGroup) autoScalingGroups() ([]any, error) {
 		// ARN construction for ASGs is a bit different, usually fetched via name
 		// We'd need a way to link to an existing aws.autoscaling.group resource.
 		// For now, returning basic info. A full resource link would require aws.autoscaling.group to be an init-able resource by name+region.
-		asgRes, err := NewResource(dg.MqlRuntime, "aws.autoscaling.group", map[string]*llx.RawData{
+		asgRes, err := NewResource(dg.MqlRuntime, ResourceAwsAutoscalingGroup, map[string]*llx.RawData{
 			"name":   llx.StringData(*asg.Name),
 			"region": llx.StringData(dg.Region.Data),
 			// ARN might need to be constructed or looked up if not directly available