Skip to content

Commit 1edac1d

Browse files
tas50claude
andcommitted
🐛 Fix SageMaker resource bugs; replace vpcSecurityGroups/vpcSubnets with vpc reference
- Replace vpcSecurityGroups/vpcSubnets typed lists with single vpc() aws.vpc reference on model, trainingJob, processingJob, and cluster resources - Deprecate vpcConfig() dict fields in favor of vpc() reference - Add init functions for domain and modelPackageGroup to fix cross-reference resolution from space, userProfile, and modelPackage resources - Add missing tag filtering to getUserProfiles (was silently skipping filters) - Remove privatePrimaryIp from clusterNode (not available from ListClusterNodes API) - Fix cached errors becoming permanent in fetchDetails for cluster, featureGroup, modelPackage, modelPackageGroup, modelCard, space, and userProfile - Bump provider version to 13.12.0 - Remove KSK and kustomize from spell check expect.txt Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7aba4f7 commit 1edac1d

File tree

8 files changed

+372
-438
lines changed

8 files changed

+372
-438
lines changed

.github/actions/spelling/expect.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,7 @@ kerberoastable
145145
keyspace
146146
kqueue
147147
krbtgt
148-
KSK
149148
kustomization
150-
kustomize
151149
kubenet
152150
labelmatchstatement
153151
launchconfiguration

providers/aws/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
var Config = plugin.Provider{
1515
Name: "aws",
1616
ID: "go.mondoo.com/cnquery/v9/providers/aws",
17-
Version: "13.10.1",
17+
Version: "13.12.0",
1818
ConnectionTypes: []string{provider.DefaultConnectionType, string(awsec2ebsconn.EBSConnectionType)},
1919
Connectors: []plugin.Connector{
2020
{

providers/aws/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ require (
7979
github.com/aws/aws-sdk-go-v2/service/route53domains v1.34.19
8080
github.com/aws/aws-sdk-go-v2/service/s3 v1.99.0
8181
github.com/aws/aws-sdk-go-v2/service/s3control v1.69.0
82-
github.com/aws/aws-sdk-go-v2/service/sagemaker v1.238.0
82+
github.com/aws/aws-sdk-go-v2/service/sagemaker v1.239.0
8383
github.com/aws/aws-sdk-go-v2/service/scheduler v1.17.22
8484
github.com/aws/aws-sdk-go-v2/service/secretsmanager v1.41.5
8585
github.com/aws/aws-sdk-go-v2/service/securityhub v1.68.3

providers/aws/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,8 +317,8 @@ github.com/aws/aws-sdk-go-v2/service/s3 v1.99.0 h1:hlSuz394kV0vhv9drL5lhuEFbEOEP
317317
github.com/aws/aws-sdk-go-v2/service/s3 v1.99.0/go.mod h1:uoA43SdFwacedBfSgfFSjjCvYe8aYBS7EnU5GZ/YKMM=
318318
github.com/aws/aws-sdk-go-v2/service/s3control v1.69.0 h1:rJNPSXP9gjaHz+OCnmeYCpk28AJefgIHv52re9uHVok=
319319
github.com/aws/aws-sdk-go-v2/service/s3control v1.69.0/go.mod h1:uaFd207QRYURS41DhU0riuwnVm/EMKA1FDt9dvsvUUY=
320-
github.com/aws/aws-sdk-go-v2/service/sagemaker v1.238.0 h1:5jLvLVu20tlFgVOsX+ns4jNVzoUWP36AQc5sAvNJSMI=
321-
github.com/aws/aws-sdk-go-v2/service/sagemaker v1.238.0/go.mod h1:zsRrjJIfG9a9b3VRU+uPa3dX5fqgI+zKMXD4tbIlbdA=
320+
github.com/aws/aws-sdk-go-v2/service/sagemaker v1.239.0 h1:aIM4M5eVgODEoSmaUa7jT4PtI2HwsqSElVory6ug+ZM=
321+
github.com/aws/aws-sdk-go-v2/service/sagemaker v1.239.0/go.mod h1:zsRrjJIfG9a9b3VRU+uPa3dX5fqgI+zKMXD4tbIlbdA=
322322
github.com/aws/aws-sdk-go-v2/service/scheduler v1.17.22 h1:W6iJpVVBijigufAXBm8f9xoG8YvpKZv+rQaUC0bT4Tc=
323323
github.com/aws/aws-sdk-go-v2/service/scheduler v1.17.22/go.mod h1:bIL40EgncO7wiyLB3Od2CkxEbU/REwG16lncm7jGqNA=
324324
github.com/aws/aws-sdk-go-v2/service/secretsmanager v1.41.5 h1:z2ayoK3pOvf8ODj/vPR0FgAS5ONruBq0F94SRoW/BIU=

providers/aws/resources/aws.lr

Lines changed: 12 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1753,12 +1753,10 @@ private aws.sagemaker.model @defaults("arn name") {
17531753
iamRole() aws.iam.role
17541754
// Primary container definition
17551755
primaryContainer() dict
1756-
// VPC configuration
1756+
// Deprecated: Use vpc instead. Raw VPC configuration dict
17571757
vpcConfig() dict
1758-
// VPC security groups from VPC configuration
1759-
vpcSecurityGroups() []aws.ec2.securitygroup
1760-
// VPC subnets from VPC configuration
1761-
vpcSubnets() []aws.vpc.subnet
1758+
// VPC associated with this model
1759+
vpc() aws.vpc
17621760
}
17631761

17641762
// AWS SageMaker training job
@@ -1793,12 +1791,10 @@ private aws.sagemaker.trainingjob @defaults("arn name status") {
17931791
failureReason() string
17941792
// Billable time in seconds
17951793
billableTimeInSeconds() int
1796-
// VPC configuration
1794+
// Deprecated: Use vpc instead. Raw VPC configuration dict
17971795
vpcConfig() dict
1798-
// VPC security groups from VPC configuration
1799-
vpcSecurityGroups() []aws.ec2.securitygroup
1800-
// VPC subnets from VPC configuration
1801-
vpcSubnets() []aws.vpc.subnet
1796+
// VPC associated with this training job
1797+
vpc() aws.vpc
18021798
// Output data configuration
18031799
outputDataConfig() dict
18041800
// Resource configuration (instanceType, instanceCount, volumeSizeInGB)
@@ -1835,12 +1831,10 @@ private aws.sagemaker.processingjob @defaults("arn name status") {
18351831
enableNetworkIsolation() bool
18361832
// Whether inter-container traffic encryption is enabled
18371833
enableInterContainerTrafficEncryption() bool
1838-
// VPC configuration
1834+
// Deprecated: Use vpc instead. Raw VPC configuration dict
18391835
vpcConfig() dict
1840-
// VPC security groups from VPC configuration
1841-
vpcSecurityGroups() []aws.ec2.securitygroup
1842-
// VPC subnets from VPC configuration
1843-
vpcSubnets() []aws.vpc.subnet
1836+
// VPC associated with this processing job
1837+
vpc() aws.vpc
18441838
// Processing resources configuration
18451839
processingResources() dict
18461840
// Environment variables
@@ -1981,12 +1975,10 @@ private aws.sagemaker.cluster @defaults("arn name status") {
19811975
instanceGroups() []dict
19821976
// Orchestrator type (EKS or Slurm configuration)
19831977
orchestrator() dict
1984-
// VPC configuration (security groups and subnets)
1978+
// Deprecated: Use vpc instead. Raw VPC configuration dict
19851979
vpcConfig() dict
1986-
// VPC security groups from VPC configuration
1987-
vpcSecurityGroups() []aws.ec2.securitygroup
1988-
// VPC subnets from VPC configuration
1989-
vpcSubnets() []aws.vpc.subnet
1980+
// VPC associated with this cluster
1981+
vpc() aws.vpc
19901982
// Node recovery mode
19911983
nodeRecovery() string
19921984
// Node provisioning mode
@@ -2013,8 +2005,6 @@ private aws.sagemaker.clusterNode @defaults("instanceId instanceGroupName instan
20132005
launchTime time
20142006
// Private DNS hostname of the node
20152007
privateDnsHostname string
2016-
// Private primary IP address
2017-
privatePrimaryIp string
20182008
// Region where the node exists
20192009
region string
20202010
}

0 commit comments

Comments
 (0)