🧹 Modernize arista and network providers with Go idioms

Use strings.Builder for string concatenation, errgroup.Go() instead of
manual Add/Done, maps.Copy for map merging, and remove redundant +build tag.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: tas50

providers/arista/resources/eos/arista_test.go

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: BUSL-1.1
 
 //go:build debugtest
-// +build debugtest
 
 package eos
 

providers/arista/resources/eos/config.go

@@ -84,7 +84,7 @@ func GetSection(in io.Reader, section string) string {
 
 	lastDepth := 0
 	lastKey := ""
-	recorded := ""
+	var recorded strings.Builder
 	for scanner.Scan() {
 		line := scanner.Text()
 		key := strings.TrimSpace(line)
@@ -115,9 +115,9 @@ func GetSection(in io.Reader, section string) string {
 		lastKey = key
 
 		if strings.Join(keyStack, " ") == " "+section {
-			recorded += key + "\n"
+			recorded.WriteString(key + "\n")
 		}
 	}
 
-	return recorded
+	return recorded.String()
 }

providers/network/resources/dnsshake/dnsshake.go

@@ -167,9 +167,7 @@ func (d *DnsClient) Query(dnsTypes ...string) (map[string]DnsRecord, error) {
 	for i := range dnsTypes {
 		dnsType := dnsTypes[i]
 
-		workers.Add(1)
-		go func() {
-			defer workers.Done()
+		workers.Go(func() {
 
 			records, err := d.queryDnsType(d.fqdn, dnsType)
 			if err != nil {
@@ -184,7 +182,7 @@ func (d *DnsClient) Query(dnsTypes ...string) (map[string]DnsRecord, error) {
 				res[k] = records[k]
 			}
 			d.sync.Unlock()
-		}()
+		})
 	}
 
 	workers.Wait()

providers/network/resources/http.go

@@ -363,14 +363,15 @@ func (x *mqlHttpHeader) contentType() (*mqlHttpHeaderContentType, error) {
 }
 
 func (x *mqlHttpHeaderContentType) id() (string, error) {
-	id := x.Type.Data
+	var id strings.Builder
+	id.WriteString(x.Type.Data)
 	if x.Params.Data != nil {
 		keys := sortx.Keys(x.Params.Data)
 		for _, key := range keys {
-			id += ";" + key + "=" + x.Params.Data[key].(string)
+			id.WriteString(";" + key + "=" + x.Params.Data[key].(string))
 		}
 	}
-	return id, nil
+	return id.String(), nil
 }
 
 func (x *mqlHttpHeader) setCookie() (*mqlHttpHeaderSetCookie, error) {

providers/network/resources/tlsshake/tlsshake.go

@@ -13,6 +13,7 @@ import (
 	"encoding/hex"
 	"errors"
 	"io"
+	"maps"
 	"math/rand"
 	"net"
 	"net/http"
@@ -154,9 +155,7 @@ func (s *Tester) Test(conf ScanConfig) error {
 	for i := range conf.Versions {
 		version := conf.Versions[i]
 
-		workers.Add(1)
-		go func() {
-			defer workers.Done()
+		workers.Go(func() {
 
 			// we don't activate any of the additional tests in the beginning
 			// let's find out if we work on this version of TLS/SSL
@@ -201,7 +200,7 @@ func (s *Tester) Test(conf ScanConfig) error {
 					_, _ = s.testTLS(s.proto, s.target, curConf)
 				}
 			}
-		}()
+		})
 	}
 
 	workers.Wait()
@@ -947,24 +946,12 @@ func init() {
 			len(TLS_CIPHERS))
 
 	// Note: overlapping names will be overwritten
-	for k, v := range SSL2_CIPHERS {
-		ALL_CIPHERS[k] = v
-	}
-	for k, v := range SSL3_CIPHERS {
-		ALL_CIPHERS[k] = v
-	}
-	for k, v := range SSL_FIPS_CIPHERS {
-		ALL_CIPHERS[k] = v
-	}
-	for k, v := range TLS10_CIPHERS {
-		ALL_CIPHERS[k] = v
-	}
-	for k, v := range TLS13_CIPHERS {
-		ALL_CIPHERS[k] = v
-	}
-	for k, v := range TLS_CIPHERS {
-		ALL_CIPHERS[k] = v
-	}
+	maps.Copy(ALL_CIPHERS, SSL2_CIPHERS)
+	maps.Copy(ALL_CIPHERS, SSL3_CIPHERS)
+	maps.Copy(ALL_CIPHERS, SSL_FIPS_CIPHERS)
+	maps.Copy(ALL_CIPHERS, TLS10_CIPHERS)
+	maps.Copy(ALL_CIPHERS, TLS13_CIPHERS)
+	maps.Copy(ALL_CIPHERS, TLS_CIPHERS)
 }
 
 const (