🐛 Fix OCI provider build: v12→v13 imports, nil safety, dead code

- Fix stale cnquery/v12 imports in 6 new resource files (cloudguard,
  events, filestorage, kms, logging, ons) and regenerated oci.lr.go
- Add nil checks for ObjectEventsEnabled and ReplicationEnabled pointer
  dereferences in buckets.go to prevent runtime panics
- Remove unused parseTime helper and its tests
- Add region tracking to KMS vault resources for future extensibility
- Add clarifying comment on CloudGuard's home-region-only strategy

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: tas50

providers/oci/resources/buckets.go

@@ -143,10 +143,11 @@ func (o *mqlOciObjectStorage) getBuckets(conn *connection.OciConnection, namespa
 				}
 
 				mqlInstance, err := CreateResource(o.MqlRuntime, "oci.objectStorage.bucket", map[string]*llx.RawData{
-					"namespace": llx.StringDataPtr(bucket.Namespace),
-					"name":      llx.StringDataPtr(bucket.Name),
-					"region":    llx.ResourceData(regionResource, "oci.region"),
-					"created":   llx.TimeDataPtr(created),
+					"namespace":     llx.StringDataPtr(bucket.Namespace),
+					"name":          llx.StringDataPtr(bucket.Name),
+					"compartmentID": llx.StringDataPtr(bucket.CompartmentId),
+					"region":        llx.ResourceData(regionResource, "oci.region"),
+					"created":       llx.TimeDataPtr(created),
 				})
 				if err != nil {
 					return nil, err
@@ -278,6 +279,9 @@ func (o *mqlOciObjectStorageBucket) objectEventsEnabled() (bool, error) {
 	if err != nil {
 		return false, err
 	}
+	if bucketInfo.ObjectEventsEnabled == nil {
+		return false, nil
+	}
 	return *bucketInfo.ObjectEventsEnabled, nil
 }
 
@@ -286,6 +290,9 @@ func (o *mqlOciObjectStorageBucket) replicationEnabled() (bool, error) {
 	if err != nil {
 		return false, err
 	}
+	if bucketInfo.ReplicationEnabled == nil {
+		return false, nil
+	}
 	return *bucketInfo.ReplicationEnabled, nil
 }
 

providers/oci/resources/cloudguard.go

@@ -10,10 +10,12 @@ import (
 
 	"github.com/oracle/oci-go-sdk/v65/cloudguard"
 	"github.com/oracle/oci-go-sdk/v65/common"
-	"go.mondoo.com/cnquery/v12/llx"
-	"go.mondoo.com/cnquery/v12/providers/oci/connection"
+	"go.mondoo.com/mql/v13/llx"
+	"go.mondoo.com/mql/v13/providers/oci/connection"
 )
 
+// CloudGuard is a tenancy-level service that only operates in the home region,
+// unlike other OCI services that require per-region iteration.
 type mqlOciCloudGuardInternal struct {
 	config     *cloudguard.Configuration
 	homeRegion string

providers/oci/resources/compute.go

@@ -293,11 +293,6 @@ func (o *mqlOciCompute) getComputeImage(conn *connection.OciConnection, regions
 					definedTags[k] = v
 				}
 
-				var sizeInMBs int64
-				if image.SizeInMBs != nil {
-					sizeInMBs = *image.SizeInMBs
-				}
-
 				// Create compartment resource reference
 				compartment, err := CreateResource(o.MqlRuntime, "oci.compartment", map[string]*llx.RawData{
 					"id": llx.StringDataPtr(image.CompartmentId),
@@ -315,7 +310,7 @@ func (o *mqlOciCompute) getComputeImage(conn *connection.OciConnection, regions
 					"compartment":            llx.ResourceData(compartment, "oci.compartment"),
 					"operatingSystem":        llx.StringDataPtr(image.OperatingSystem),
 					"operatingSystemVersion": llx.StringDataPtr(image.OperatingSystemVersion),
-					"sizeInMBs":              llx.IntData(sizeInMBs),
+					"sizeInMBs":              llx.IntDataPtr(image.SizeInMBs),
 					"freeformTags":           llx.MapData(freeformTags, types.String),
 					"definedTags":            llx.MapData(definedTags, types.Any),
 				})

providers/oci/resources/conversion.go

@@ -4,20 +4,9 @@
 package resources
 
 import (
-	"time"
-
 	"go.mondoo.com/mql/v13/providers-sdk/v1/util/jobpool"
 )
 
-// parseTime parses RFC 3389 timestamps "2019-06-12T21:14:13.190Z"
-func parseTime(timestamp string) *time.Time {
-	parsedCreated, err := time.Parse(time.RFC3339, timestamp)
-	if err != nil {
-		return nil
-	}
-	return &parsedCreated
-}
-
 func stringValue(s *string) string {
 	if s == nil {
 		return ""

providers/oci/resources/conversion_test.go

@@ -5,10 +5,8 @@ package resources
 
 import (
 	"testing"
-	"time"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func TestStringValue(t *testing.T) {
@@ -69,21 +67,3 @@ func TestIntValue(t *testing.T) {
 		assert.Equal(t, int64(42), intValue(&i))
 	})
 }
-
-func TestParseTime(t *testing.T) {
-	t.Run("valid RFC3339 timestamp", func(t *testing.T) {
-		result := parseTime("2019-06-12T21:14:13.190Z")
-		require.NotNil(t, result)
-		assert.Equal(t, 2019, result.Year())
-		assert.Equal(t, time.June, result.Month())
-		assert.Equal(t, 12, result.Day())
-	})
-
-	t.Run("invalid timestamp returns nil", func(t *testing.T) {
-		assert.Nil(t, parseTime("not-a-timestamp"))
-	})
-
-	t.Run("empty string returns nil", func(t *testing.T) {
-		assert.Nil(t, parseTime(""))
-	})
-}

providers/oci/resources/events.go

@@ -11,9 +11,9 @@ import (
 	"github.com/oracle/oci-go-sdk/v65/common"
 	"github.com/oracle/oci-go-sdk/v65/events"
 	"github.com/rs/zerolog/log"
-	"go.mondoo.com/cnquery/v12/llx"
-	"go.mondoo.com/cnquery/v12/providers-sdk/v1/util/jobpool"
-	"go.mondoo.com/cnquery/v12/providers/oci/connection"
+	"go.mondoo.com/mql/v13/llx"
+	"go.mondoo.com/mql/v13/providers-sdk/v1/util/jobpool"
+	"go.mondoo.com/mql/v13/providers/oci/connection"
 )
 
 func (o *mqlOciEvents) id() (string, error) {

providers/oci/resources/filestorage.go

@@ -12,9 +12,9 @@ import (
 	"github.com/oracle/oci-go-sdk/v65/filestorage"
 	"github.com/oracle/oci-go-sdk/v65/identity"
 	"github.com/rs/zerolog/log"
-	"go.mondoo.com/cnquery/v12/llx"
-	"go.mondoo.com/cnquery/v12/providers-sdk/v1/util/jobpool"
-	"go.mondoo.com/cnquery/v12/providers/oci/connection"
+	"go.mondoo.com/mql/v13/llx"
+	"go.mondoo.com/mql/v13/providers-sdk/v1/util/jobpool"
+	"go.mondoo.com/mql/v13/providers/oci/connection"
 )
 
 func (o *mqlOciFileStorage) id() (string, error) {

providers/oci/resources/kms.go

@@ -11,9 +11,9 @@ import (
 	"github.com/oracle/oci-go-sdk/v65/common"
 	"github.com/oracle/oci-go-sdk/v65/keymanagement"
 	"github.com/rs/zerolog/log"
-	"go.mondoo.com/cnquery/v12/llx"
-	"go.mondoo.com/cnquery/v12/providers-sdk/v1/util/jobpool"
-	"go.mondoo.com/cnquery/v12/providers/oci/connection"
+	"go.mondoo.com/mql/v13/llx"
+	"go.mondoo.com/mql/v13/providers-sdk/v1/util/jobpool"
+	"go.mondoo.com/mql/v13/providers/oci/connection"
 )
 
 func (o *mqlOciKms) id() (string, error) {
@@ -114,6 +114,7 @@ func (o *mqlOciKms) getVaults(conn *connection.OciConnection, regions []any) []*
 				if err != nil {
 					return nil, err
 				}
+				mqlInstance.(*mqlOciKmsVault).region = regionResource.Id.Data
 				res = append(res, mqlInstance)
 			}
 
@@ -124,6 +125,10 @@ func (o *mqlOciKms) getVaults(conn *connection.OciConnection, regions []any) []*
 	return tasks
 }
 
+type mqlOciKmsVaultInternal struct {
+	region string
+}
+
 func (o *mqlOciKmsVault) id() (string, error) {
 	return "oci.kms.vault/" + o.Id.Data, nil
 }

providers/oci/resources/logging.go

@@ -11,10 +11,10 @@ import (
 	"github.com/oracle/oci-go-sdk/v65/common"
 	"github.com/oracle/oci-go-sdk/v65/logging"
 	"github.com/rs/zerolog/log"
-	"go.mondoo.com/cnquery/v12/llx"
-	"go.mondoo.com/cnquery/v12/providers-sdk/v1/util/convert"
-	"go.mondoo.com/cnquery/v12/providers-sdk/v1/util/jobpool"
-	"go.mondoo.com/cnquery/v12/providers/oci/connection"
+	"go.mondoo.com/mql/v13/llx"
+	"go.mondoo.com/mql/v13/providers-sdk/v1/util/convert"
+	"go.mondoo.com/mql/v13/providers-sdk/v1/util/jobpool"
+	"go.mondoo.com/mql/v13/providers/oci/connection"
 )
 
 func (o *mqlOciLogging) id() (string, error) {

providers/oci/resources/oci.lr

@@ -206,7 +206,7 @@ private oci.compute.instance @defaults("name") {
   region oci.region
   // Instance creation time
   created time
-  // Instance lifecycle state (MOVING, PROVISIONING, RUNNING, STARTING, STOPPING, STOPPED, CREATING_IMAGE, TERMINATING, TERMINATED)
+  // Instance lifecycle state (e.g., MOVING, PROVISIONING, RUNNING, STARTING, STOPPING, STOPPED, CREATING_IMAGE, TERMINATING, TERMINATED)
   state string
   // Compute shape determining CPU and memory (e.g., VM.Standard2.1)
   shape string
@@ -248,7 +248,7 @@ private oci.compute.image @defaults("name") {
   region oci.region
   // Image creation time
   created time
-  // Image lifecycle state (PROVISIONING, IMPORTING, AVAILABLE, EXPORTING, DISABLED, DELETED)
+  // Image lifecycle state (e.g., PROVISIONING, IMPORTING, AVAILABLE, EXPORTING, DISABLED, DELETED)
   state string
   // Compartment containing the image
   compartment oci.compartment
@@ -332,7 +332,7 @@ private oci.network.vcn @defaults("name") {
   name string
   // VCN creation time
   created time
-  // VCN lifecycle state (PROVISIONING, AVAILABLE, UPDATING, TERMINATING, TERMINATED)
+  // VCN lifecycle state (e.g., PROVISIONING, AVAILABLE, TERMINATING, TERMINATED, UPDATING)
   state string
   // Deprecated: Use cidrBlocks instead
   cidrBlock string
@@ -364,7 +364,7 @@ private oci.network.securityList @defaults("name") {
   name string
   // Security list creation time
   created time
-  // Security list lifecycle state (PROVISIONING, AVAILABLE, TERMINATING, TERMINATED)
+  // Security list lifecycle state (e.g., PROVISIONING, AVAILABLE, TERMINATING, TERMINATED)
   state string
   // Egress security rules for outbound traffic
   egressSecurityRules []dict