🧹 Convert enable/disable string enums to bool in AWS resources

SageMaker directInternetAccess/rootAccess and transit gateway
autoAcceptSharedAttachments/defaultRouteTableAssociation/
defaultRouteTablePropagation/dnsSupport/multicastSupport/
vpnEcmpSupport are all two-state enums that map naturally to bool.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: tas50

providers/aws/resources/aws.lr

@@ -1398,9 +1398,9 @@ private aws.sagemaker.notebookinstancedetails @defaults("arn") {
   // KMS key used to encrypt data
   kmsKey() aws.kms.key
   // Whether SageMaker provides internet access to the instance
-  directInternetAccess string
+  directInternetAccess bool
   // Whether root access is enabled for users of the notebook instance
-  rootAccess string
+  rootAccess bool
   // Minimum IMDS version the notebook instance supports (1 or 2)
   minimumInstanceMetadataServiceVersion string
   // VPC subnet the notebook instance is deployed in
@@ -4656,18 +4656,18 @@ private aws.ec2.transitgateway @defaults("arn id state") {
   tags map[string]string
   // Private Autonomous System Number (ASN) for the Amazon side of a BGP session
   amazonSideAsn int
-  // Whether attachment requests are automatically accepted (enable or disable)
-  autoAcceptSharedAttachments string
-  // Whether resource attachments are automatically associated with the default route table (enable or disable)
-  defaultRouteTableAssociation string
-  // Whether resource attachments automatically propagate routes to the default route table (enable or disable)
-  defaultRouteTablePropagation string
-  // Whether DNS support is enabled (enable or disable)
-  dnsSupport string
-  // Whether multicast is enabled (enable or disable)
-  multicastSupport string
-  // Whether Equal Cost Multipath Protocol support is enabled (enable or disable)
-  vpnEcmpSupport string
+  // Whether attachment requests are automatically accepted
+  autoAcceptSharedAttachments bool
+  // Whether resource attachments are automatically associated with the default route table
+  defaultRouteTableAssociation bool
+  // Whether resource attachments automatically propagate routes to the default route table
+  defaultRouteTablePropagation bool
+  // Whether DNS support is enabled
+  dnsSupport bool
+  // Whether multicast is enabled
+  multicastSupport bool
+  // Whether Equal Cost Multipath Protocol support is enabled
+  vpnEcmpSupport bool
   // Transit gateway CIDR blocks
   transitGatewayCidrBlocks []string
   // ID of the default association route table

providers/aws/resources/aws.lr.go

@@ -2224,20 +2224,20 @@ func (a *mqlAwsEc2) getTransitGateways(conn *connection.AwsConnection) []*jobpoo
 
 					// Flatten Options
 					var amazonSideAsn int64
-					var autoAcceptSharedAttachments, defaultRouteTableAssociation, defaultRouteTablePropagation string
-					var dnsSupport, multicastSupport, vpnEcmpSupport string
+					var autoAcceptSharedAttachments, defaultRouteTableAssociation, defaultRouteTablePropagation bool
+					var dnsSupport, multicastSupport, vpnEcmpSupport bool
 					var transitGatewayCidrBlocks []string
 					var associationDefaultRouteTableId, propagationDefaultRouteTableId string
 					if opts := tgw.Options; opts != nil {
 						if opts.AmazonSideAsn != nil {
 							amazonSideAsn = *opts.AmazonSideAsn
 						}
-						autoAcceptSharedAttachments = string(opts.AutoAcceptSharedAttachments)
-						defaultRouteTableAssociation = string(opts.DefaultRouteTableAssociation)
-						defaultRouteTablePropagation = string(opts.DefaultRouteTablePropagation)
-						dnsSupport = string(opts.DnsSupport)
-						multicastSupport = string(opts.MulticastSupport)
-						vpnEcmpSupport = string(opts.VpnEcmpSupport)
+						autoAcceptSharedAttachments = string(opts.AutoAcceptSharedAttachments) == "enable"
+						defaultRouteTableAssociation = string(opts.DefaultRouteTableAssociation) == "enable"
+						defaultRouteTablePropagation = string(opts.DefaultRouteTablePropagation) == "enable"
+						dnsSupport = string(opts.DnsSupport) == "enable"
+						multicastSupport = string(opts.MulticastSupport) == "enable"
+						vpnEcmpSupport = string(opts.VpnEcmpSupport) == "enable"
 						transitGatewayCidrBlocks = opts.TransitGatewayCidrBlocks
 						associationDefaultRouteTableId = convert.ToValue(opts.AssociationDefaultRouteTableId)
 						propagationDefaultRouteTableId = convert.ToValue(opts.PropagationDefaultRouteTableId)
@@ -2254,12 +2254,12 @@ func (a *mqlAwsEc2) getTransitGateways(conn *connection.AwsConnection) []*jobpoo
 							"createdAt":                      llx.TimeDataPtr(tgw.CreationTime),
 							"tags":                           llx.MapData(toInterfaceMap(ec2TagsToMap(tgw.Tags)), types.String),
 							"amazonSideAsn":                  llx.IntData(amazonSideAsn),
-							"autoAcceptSharedAttachments":    llx.StringData(autoAcceptSharedAttachments),
-							"defaultRouteTableAssociation":   llx.StringData(defaultRouteTableAssociation),
-							"defaultRouteTablePropagation":   llx.StringData(defaultRouteTablePropagation),
-							"dnsSupport":                     llx.StringData(dnsSupport),
-							"multicastSupport":               llx.StringData(multicastSupport),
-							"vpnEcmpSupport":                 llx.StringData(vpnEcmpSupport),
+							"autoAcceptSharedAttachments":    llx.BoolData(autoAcceptSharedAttachments),
+							"defaultRouteTableAssociation":   llx.BoolData(defaultRouteTableAssociation),
+							"defaultRouteTablePropagation":   llx.BoolData(defaultRouteTablePropagation),
+							"dnsSupport":                     llx.BoolData(dnsSupport),
+							"multicastSupport":               llx.BoolData(multicastSupport),
+							"vpnEcmpSupport":                 llx.BoolData(vpnEcmpSupport),
 							"transitGatewayCidrBlocks":       llx.ArrayData(convert.SliceAnyToInterface(transitGatewayCidrBlocks), types.String),
 							"associationDefaultRouteTableId": llx.StringData(associationDefaultRouteTableId),
 							"propagationDefaultRouteTableId": llx.StringData(propagationDefaultRouteTableId),

providers/aws/resources/aws_ec2.go

@@ -237,8 +237,8 @@ func (a *mqlAwsSagemakerNotebookinstance) details() (*mqlAwsSagemakerNotebookins
 	}
 	args := map[string]*llx.RawData{
 		"arn":                  llx.StringDataPtr(instanceDetails.NotebookInstanceArn),
-		"directInternetAccess": llx.StringData(string(instanceDetails.DirectInternetAccess)),
-		"rootAccess":           llx.StringData(string(instanceDetails.RootAccess)),
+		"directInternetAccess": llx.BoolData(string(instanceDetails.DirectInternetAccess) == "Enabled"),
+		"rootAccess":           llx.BoolData(string(instanceDetails.RootAccess) == "Enabled"),
 	}
 	if instanceDetails.InstanceMetadataServiceConfiguration != nil {
 		args["minimumInstanceMetadataServiceVersion"] = llx.StringDataPtr(instanceDetails.InstanceMetadataServiceConfiguration.MinimumInstanceMetadataServiceVersion)