Skip to content

Commit 402e9ed

Browse files
tas50claude
andcommitted
Address review: fix spellcheck, use stable IAM binding IDs
- Add KFP to spelling expect list to fix CI spellcheck failure. - Use role-based IAM binding IDs (repoPath + "/" + role) instead of index-based IDs for stability across API call reordering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4260dc7 commit 402e9ed

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/actions/spelling/expect.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ ipsetreferencestatement
101101
istio
102102
jira
103103
jsonbody
104+
KFP
104105
kqueue
105106
KSK
106107
labelmatchstatement

providers/gcp/resources/artifactregistry.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88
"errors"
99
"fmt"
1010
"sort"
11-
"strconv"
1211
"time"
1312

1413
artifactregistry "cloud.google.com/go/artifactregistry/apiv1"
@@ -257,9 +256,9 @@ func (g *mqlGcpProjectArtifactRegistryServiceRepository) iamPolicy() ([]any, err
257256
return nil, err
258257
}
259258
res := make([]any, 0, len(policy.Bindings))
260-
for i, b := range policy.Bindings {
259+
for _, b := range policy.Bindings {
261260
mqlBinding, err := CreateResource(g.MqlRuntime, "gcp.resourcemanager.binding", map[string]*llx.RawData{
262-
"id": llx.StringData(repoPath + "-" + strconv.Itoa(i)),
261+
"id": llx.StringData(repoPath + "/" + b.Role),
263262
"role": llx.StringData(b.Role),
264263
"members": llx.ArrayData(convert.SliceAnyToInterface(b.Members), types.String),
265264
})

0 commit comments

Comments
 (0)