Skip to content

Commit 43d1da5

Browse files
tas50claude
andcommitted
🧹 Address PR review: fix nil deref, remove unsupported fields, fix licenses
- Fix nil dereference in functions.go when fn.Properties is nil - Remove minimumTlsVersion/publicNetworkAccess from Service Bus namespace (not available in armservicebus v1.2.0 SDK, v2 is beta-only) - Fix copyright headers to match existing convention (2024, 2026) - Add frontdoor/functionapp to spelling expect.txt Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 473750a commit 43d1da5

File tree

9 files changed

+27
-60
lines changed

9 files changed

+27
-60
lines changed

‎.github/actions/spelling/expect.txt‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,10 @@ firestore
9494
FLEXGROUP
9595
FLEXVOL
9696
fortios
97+
frontdoor
9798
frontmatter
9899
ftps
100+
functionapp
99101
fumadocs
100102
gcfs
101103
gcs

‎providers/azure/resources/azure.lr‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4711,10 +4711,6 @@ azure.subscription.serviceBusService.namespace @defaults("id name location") {
47114711
serviceBusEndpoint string
47124712
// Whether local (SAS key) authentication is disabled
47134713
disableLocalAuth bool
4714-
// Minimum TLS version (e.g., "1.0", "1.1", "1.2")
4715-
minimumTlsVersion string
4716-
// Public network access (Enabled, Disabled, SecuredByPerimeter)
4717-
publicNetworkAccess string
47184714
// Queues in this namespace
47194715
queues() []azure.subscription.serviceBusService.namespace.queue
47204716
// Topics in this namespace

‎providers/azure/resources/azure.lr.go‎

Lines changed: 10 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎providers/azure/resources/azure.lr.versions‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1733,9 +1733,7 @@ azure.subscription.serviceBusService.namespace 13.3.3
17331733
azure.subscription.serviceBusService.namespace.disableLocalAuth 13.3.3
17341734
azure.subscription.serviceBusService.namespace.id 13.3.3
17351735
azure.subscription.serviceBusService.namespace.location 13.3.3
1736-
azure.subscription.serviceBusService.namespace.minimumTlsVersion 13.3.3
17371736
azure.subscription.serviceBusService.namespace.name 13.3.3
1738-
azure.subscription.serviceBusService.namespace.publicNetworkAccess 13.3.3
17391737
azure.subscription.serviceBusService.namespace.queue 13.3.3
17401738
azure.subscription.serviceBusService.namespace.queue.deadLetterMessageCount 13.3.3
17411739
azure.subscription.serviceBusService.namespace.queue.defaultMessageTimeToLive 13.3.3

‎providers/azure/resources/dns.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright Mondoo, Inc. 2026
1+
// Copyright Mondoo, Inc. 2024, 2026
22
// SPDX-License-Identifier: BUSL-1.1
33

44
package resources

‎providers/azure/resources/eventhub.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright Mondoo, Inc. 2026
1+
// Copyright Mondoo, Inc. 2024, 2026
22
// SPDX-License-Identifier: BUSL-1.1
33

44
package resources

‎providers/azure/resources/frontdoor.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright Mondoo, Inc. 2026
1+
// Copyright Mondoo, Inc. 2024, 2026
22
// SPDX-License-Identifier: BUSL-1.1
33

44
package resources

‎providers/azure/resources/functions.go‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright Mondoo, Inc. 2026
1+
// Copyright Mondoo, Inc. 2024, 2026
22
// SPDX-License-Identifier: BUSL-1.1
33

44
package resources
@@ -157,14 +157,11 @@ func (a *mqlAzureSubscriptionFunctionsServiceFunctionApp) functions() ([]any, er
157157
continue
158158
}
159159

160-
config, err := convert.JsonToDict(fn.Properties.Config)
161-
if err != nil {
162-
config = nil
163-
}
164-
160+
var config any
165161
var language string
166162
var isDisabled bool
167163
if fn.Properties != nil {
164+
config, _ = convert.JsonToDict(fn.Properties.Config)
168165
if fn.Properties.Language != nil {
169166
language = *fn.Properties.Language
170167
}

‎providers/azure/resources/servicebus.go‎

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright Mondoo, Inc. 2026
1+
// Copyright Mondoo, Inc. 2024, 2026
22
// SPDX-License-Identifier: BUSL-1.1
33

44
package resources
@@ -95,16 +95,14 @@ func (a *mqlAzureSubscriptionServiceBusService) namespaces() ([]any, error) {
9595
}
9696

9797
mqlNs, err := CreateResource(a.MqlRuntime, "azure.subscription.serviceBusService.namespace", map[string]*llx.RawData{
98-
"id": llx.StringDataPtr(ns.ID),
99-
"name": llx.StringDataPtr(ns.Name),
100-
"location": llx.StringDataPtr(ns.Location),
101-
"tags": llx.MapData(convert.PtrMapStrToInterface(ns.Tags), types.String),
102-
"sku": llx.DictData(sku),
103-
"status": llx.StringData(status),
104-
"serviceBusEndpoint": llx.StringData(serviceBusEndpoint),
105-
"disableLocalAuth": llx.BoolData(disableLocalAuth),
106-
"minimumTlsVersion": llx.StringData(""),
107-
"publicNetworkAccess": llx.StringData(""),
98+
"id": llx.StringDataPtr(ns.ID),
99+
"name": llx.StringDataPtr(ns.Name),
100+
"location": llx.StringDataPtr(ns.Location),
101+
"tags": llx.MapData(convert.PtrMapStrToInterface(ns.Tags), types.String),
102+
"sku": llx.DictData(sku),
103+
"status": llx.StringData(status),
104+
"serviceBusEndpoint": llx.StringData(serviceBusEndpoint),
105+
"disableLocalAuth": llx.BoolData(disableLocalAuth),
108106
})
109107
if err != nil {
110108
return nil, err

0 commit comments

Comments
 (0)