🧹 Fix logindefs resource, allow for trailing comments (#5536)

* fix logindefs, allow for trailing comments

Signed-off-by: Manuel Weber <manuel@mondoo.com>

* update testdata

Signed-off-by: Manuel Weber <manuel@mondoo.com>

* update testdata

Signed-off-by: Manuel Weber <manuel@mondoo.com>

* updated test

Signed-off-by: Manuel Weber <manuel@mondoo.com>

---------

Signed-off-by: Manuel Weber <manuel@mondoo.com>

Author: mm-weber

providers/os/resources/logindefs/logindefs.go

@@ -13,8 +13,8 @@ import (
 func Parse(r io.Reader) map[string]string {
 	res := map[string]string{}
 
-	// ignore line if it starts with a comment
-	logindefEntry := regexp.MustCompile(`^\s*([^#]\S+)\s+(\S+)\s*$`)
+	// ignore line if it starts with a comment, allow trailing comments though
+	logindefEntry := regexp.MustCompile(`^\s*([^#]\S+)\s+(\S+)\s*(?:#.*)?$`)
 
 	scanner := bufio.NewScanner(r)
 	for scanner.Scan() {

providers/os/resources/logindefs/logindefs_test.go

@@ -25,6 +25,7 @@ func TestLoginDefsParser(t *testing.T) {
 
 	assert.Equal(t, "tty", entries["TTYGROUP"])
 	assert.Equal(t, "PATH=/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games", entries["ENV_PATH"])
+	assert.Equal(t, "1", entries["PASS_MIN_DAYS"])
 
 	_, ok := entries["SHA_CRYPT_MIN_ROUNDS"]
 	assert.False(t, ok)

providers/os/resources/logindefs/testdata/debian.toml

@@ -160,7 +160,7 @@ UMASK		022
 #	PASS_WARN_AGE	Number of days warning given before a password expires.
 #
 PASS_MAX_DAYS	99999
-PASS_MIN_DAYS	0
+PASS_MIN_DAYS	1   # Updated automatically
 PASS_WARN_AGE	7
 
 #