🧹 Remove allDiscovery() in favor of All (aws, azure, gcp)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: preslavgerchev

providers/aws/resources/discovery.go

@@ -134,10 +134,6 @@ var All = append(
 	DiscoveryECS,
 )
 
-func allDiscovery() []string {
-	return All
-}
-
 func Discover(runtime *plugin.Runtime) (*inventory.Inventory, error) {
 	conn := runtime.Connection.(*connection.AwsConnection)
 	in := &inventory.Inventory{Spec: &inventory.InventorySpec{
@@ -168,7 +164,7 @@ func getDiscoveryTargets(config *inventory.Config) []string {
 
 	if stringx.Contains(targets, DiscoveryAll) {
 		// return the All list + All Api Resources list
-		return allDiscovery()
+		return All
 	}
 
 	// the targets we return.

providers/aws/resources/discovery_test.go

@@ -348,7 +348,7 @@ func TestDiscoveryAndFilterPropagation(t *testing.T) {
 		}{
 			{"empty returns empty (ParseCLI sets default)", []string{}, []string{}},
 			{"auto keyword", []string{"auto"}, Auto},
-			{"all keyword", []string{"all"}, allDiscovery()},
+			{"all keyword", []string{"all"}, All},
 			{"resources keyword", []string{"resources"}, AllAPIResources},
 			{"explicit single", []string{"s3-buckets"}, []string{DiscoveryS3Buckets}},
 			{
@@ -357,7 +357,7 @@ func TestDiscoveryAndFilterPropagation(t *testing.T) {
 				[]string{DiscoveryS3Buckets, DiscoveryInstances, DiscoveryIAMUsers},
 			},
 			{"auto takes precedence", []string{"auto", "s3-buckets"}, Auto},
-			{"all takes precedence", []string{"all", "s3-buckets"}, allDiscovery()},
+			{"all takes precedence", []string{"all", "s3-buckets"}, All},
 		}
 
 		for _, tc := range cases {
@@ -462,7 +462,7 @@ func TestGetDiscoveryTargets(t *testing.T) {
 		{
 			name:    "all",
 			targets: []string{"all"},
-			want:    allDiscovery(),
+			want:    All,
 		},
 		{
 			name:    "auto",
@@ -482,12 +482,12 @@ func TestGetDiscoveryTargets(t *testing.T) {
 		{
 			name:    "all and resources",
 			targets: []string{"all", "resources"},
-			want:    allDiscovery(),
+			want:    All,
 		},
 		{
 			name:    "all, auto and resources",
 			targets: []string{"all", "resources"},
-			want:    allDiscovery(),
+			want:    All,
 		},
 		{
 			name:    "random",

providers/azure/resources/discovery.go

@@ -66,10 +66,6 @@ var All = append(
 	DiscoveryStorageContainers,
 )
 
-func allDiscovery() []string {
-	return All
-}
-
 var AllAPIResources = []string{
 	DiscoveryInstancesApi,
 	DiscoverySqlServers,
@@ -125,7 +121,7 @@ func getDiscoveryTargets(config *inventory.Config) []string {
 	}
 	if stringx.ContainsAnyOf(targets, DiscoveryAll) {
 		// return the All list + All Api Resources list
-		return allDiscovery()
+		return All
 	}
 	if stringx.ContainsAnyOf(targets, DiscoveryAuto) {
 		for i, target := range targets {

providers/azure/resources/discovery_test.go

@@ -71,12 +71,12 @@ func TestGetDiscoveryTargets(t *testing.T) {
 		{
 			name:    "all",
 			targets: []string{"all"},
-			want:    allDiscovery(),
+			want:    All,
 		},
 		{
 			name:    "all with extras",
 			targets: []string{"all", "projects", "instances"},
-			want:    allDiscovery(),
+			want:    All,
 		},
 		{
 			name:    "auto",

providers/gcp/resources/discovery.go

@@ -63,10 +63,6 @@ const (
 // All includes every discovery target: Auto covers all of them for GCP.
 var All = slices.Clone(Auto)
 
-func allDiscovery() []string {
-	return All
-}
-
 var Auto = []string{
 	DiscoveryOrganization,
 	DiscoveryFolders,
@@ -140,7 +136,7 @@ func getDiscoveryTargets(config *inventory.Config) []string {
 
 	if stringx.ContainsAnyOf(targets, DiscoveryAll) {
 		// return the All list + All Api Resources list
-		return allDiscovery()
+		return All
 	}
 	if stringx.ContainsAnyOf(targets, DiscoveryAuto) {
 		for i, target := range targets {

providers/gcp/resources/discovery_test.go

@@ -95,12 +95,12 @@ func TestGetDiscoveryTargets(t *testing.T) {
 		{
 			name:    "all",
 			targets: []string{"all"},
-			want:    allDiscovery(),
+			want:    All,
 		},
 		{
 			name:    "all with extras",
 			targets: []string{"all", "projects", "instances"},
-			want:    allDiscovery(),
+			want:    All,
 		},
 		{
 			name:    "auto",