✨ Support rpm modules for AlmaLinux

Related to #6391

Signed-off-by: Christian Zunker <christian@mondoo.com>

Author: czunker

providers/os/resources/packages/rpm_packages.go

@@ -13,6 +13,7 @@ import (
 	"strconv"
 	"strings"
 
+	"go.mondoo.com/cnquery/v12/providers/core/resources/versions/semver"
 	"go.mondoo.com/cnquery/v12/providers/os/resources/cpe"
 	"go.mondoo.com/cnquery/v12/providers/os/resources/purl"
 
@@ -374,12 +375,22 @@ func (spm *SusePkgManager) Available() (map[string]PackageUpdate, error) {
 // Not every rpm based distro supports modules.
 // E.g. SLES and Amazon Linux 2023 do not support modularity.
 // Amazon Linux 2 supports modularity.
+// No more modules starting with RHEL v10: https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/10/html/considerations_in_adopting_rhel_10/application-streams
 func modularitySupportedByPlatform(platform *inventory.Platform) bool {
 	supported := false
 
 	switch platform.Name {
-	case "oraclelinux":
-		supported = true
+	case "oraclelinux", "almalinux":
+		vParser := semver.Parser{}
+		cmp, err := vParser.Compare(platform.Version, "10")
+		if err != nil {
+			return false
+		}
+		if cmp < 0 {
+			supported = true
+		} else {
+			supported = false
+		}
 	}
 
 	return supported

providers/os/resources/packages/rpm_packages_test.go

@@ -428,3 +428,75 @@ func TestOracleParser(t *testing.T) {
 	fPkg = findPkg(m, p.Name)
 	assert.Equal(t, p.PUrl, fPkg.PUrl)
 }
+
+func TestAlmaLinuxParser(t *testing.T) {
+	mock, err := mock.New(0, &inventory.Asset{}, mock.WithPath("./testdata/packages_almalinux.toml"))
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	pf := &inventory.Platform{
+		Name:    "almalinux",
+		Version: "8.10",
+		Arch:    "x86_64",
+		Family:  []string{"redhat", "linux", "unix", "os"},
+		Labels: map[string]string{
+			"distro-id": "almalinux",
+		},
+	}
+
+	c, err := mock.RunCommand("rpm -qa --queryformat '%{NAME} %{EPOCHNUM}:%{VERSION}-%{RELEASE} %{ARCH}__%{VENDOR}__%{SUMMARY}__%{MODULARITYLABEL}\\n'")
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	m := ParseRpmPackages(pf, c.Stdout)
+	require.Equal(t, 6, len(m))
+
+	p := Package{
+		Name: "php-cli",
+		PUrl: "pkg:rpm/almalinux/php-cli@7.4.33-2.module_el8.10.0%2B3935%2B28808425?arch=aarch64&distro=almalinux-8.10&rpmmod=php%3A7.4%3A8100020241212065510%3Aeb0869e2",
+	}
+	fPkg := findPkg(m, p.Name)
+	assert.Equal(t, p.PUrl, fPkg.PUrl)
+}
+
+func TestModularitySupportedByPlatform(t *testing.T) {
+	tests := []struct {
+		name     string
+		platform *inventory.Platform
+		want     bool
+	}{
+		{
+			name:     "AlmaLinux",
+			platform: &inventory.Platform{Name: "almalinux", Version: "8.10", Arch: "x86_64"},
+			want:     true,
+		},
+		{
+			name:     "OracleLinux",
+			platform: &inventory.Platform{Name: "oraclelinux", Version: "9", Arch: "x86_64"},
+			want:     true,
+		},
+		{
+			name:     "AlmaLinux",
+			platform: &inventory.Platform{Name: "almalinux", Version: "10", Arch: "x86_64"},
+			want:     false,
+		},
+		{
+			name:     "OracleLinux",
+			platform: &inventory.Platform{Name: "oraclelinux", Version: "10.1", Arch: "x86_64"},
+			want:     false,
+		},
+		{
+			name:     "AmazonLinux",
+			platform: &inventory.Platform{Name: "amazonlinux", Version: "2", Arch: "x86_64"},
+			want:     false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			require.Equal(t, tt.want, modularitySupportedByPlatform(tt.platform))
+		})
+	}
+}

providers/os/resources/packages/testdata/packages_almalinux.toml

@@ -0,0 +1,15 @@
+[commands."command -v rpm"]
+stdout="/usr/bin/rpm"
+
+[commands."rpm -E '%{_dbpath}'"]
+stdout="/var/lib/rpm"
+
+[commands."rpm -qa --queryformat '%{NAME} %{EPOCHNUM}:%{VERSION}-%{RELEASE} %{ARCH}__%{VENDOR}__%{SUMMARY}__%{MODULARITYLABEL}\\n'"]
+stdout="""
+php-xml 0:7.4.33-2.module_el8.10.0+3935+28808425 aarch64__AlmaLinux__A module for PHP applications which use XML__php:7.4:8100020241212065510:eb0869e2
+php-mbstring 0:7.4.33-2.module_el8.10.0+3935+28808425 aarch64__AlmaLinux__A module for PHP applications which need multi-byte string handling__php:7.4:8100020241212065510:eb0869e2
+php-common 0:7.4.33-2.module_el8.10.0+3935+28808425 aarch64__AlmaLinux__Common files for PHP__php:7.4:8100020241212065510:eb0869e2
+php-cli 0:7.4.33-2.module_el8.10.0+3935+28808425 aarch64__AlmaLinux__Command-line interface for PHP__php:7.4:8100020241212065510:eb0869e2
+php-fpm 0:7.4.33-2.module_el8.10.0+3935+28808425 aarch64__AlmaLinux__PHP FastCGI Process Manager__php:7.4:8100020241212065510:eb0869e2
+php-json 0:7.4.33-2.module_el8.10.0+3935+28808425 aarch64__AlmaLinux__JavaScript Object Notation extension for PHP__php:7.4:8100020241212065510:eb0869e2
+"""