Add support for packages on OpenBSD (#6607)

It's similar to other BSD systems but of course it's different.

Signed-off-by: Tim Smith <tsmith84@gmail.com>

Author: tas50

providers/os/resources/packages/openbsd_packages.go

@@ -0,0 +1,98 @@
+// Copyright (c) Mondoo, Inc.
+// SPDX-License-Identifier: BUSL-1.1
+
+package packages
+
+import (
+	"bufio"
+	"fmt"
+	"io"
+	"strings"
+
+	"github.com/rs/zerolog/log"
+
+	"go.mondoo.com/cnquery/v12/providers/os/connection/shared"
+)
+
+const (
+	OpenbsdPkgFormat = "openbsd"
+)
+
+// ParseOpenbsdPackages parses the output of 'pkg_info -a' on OpenBSD.
+// Each line has the format: name-version  description
+func ParseOpenbsdPackages(r io.Reader) ([]Package, error) {
+	pkgs := []Package{}
+
+	scanner := bufio.NewScanner(r)
+	for scanner.Scan() {
+		line := scanner.Text()
+		if strings.TrimSpace(line) == "" {
+			continue
+		}
+
+		pkg, err := parseOpenbsdPackageLine(line)
+		if err != nil {
+			log.Debug().Err(err).Msg("skipping invalid openbsd package line")
+			continue
+		}
+		pkgs = append(pkgs, pkg)
+	}
+
+	if err := scanner.Err(); err != nil {
+		return nil, err
+	}
+
+	return pkgs, nil
+}
+
+// parseOpenbsdPackageLine parses a single line from pkg_info output.
+// Format: "name-version  description text"
+// The name-version field never contains spaces, so we split on the first space.
+func parseOpenbsdPackageLine(line string) (Package, error) {
+	idx := strings.IndexByte(line, ' ')
+	if idx == -1 {
+		return Package{}, fmt.Errorf("could not parse package line: %s", line)
+	}
+
+	nameVersion := line[:idx]
+	description := strings.TrimSpace(line[idx:])
+
+	// Split name and version using the same regex as NetBSD.
+	// Package names can contain hyphens; the version starts with a digit.
+	matches := netbsdPkgNameRegex.FindStringSubmatch(nameVersion)
+	if len(matches) != 3 {
+		return Package{}, fmt.Errorf("could not parse package name and version from: %s", nameVersion)
+	}
+
+	return Package{
+		Name:        matches[1],
+		Version:     matches[2],
+		Description: description,
+		Format:      OpenbsdPkgFormat,
+	}, nil
+}
+
+type OpenBSDPkgManager struct {
+	conn shared.Connection
+}
+
+func (o *OpenBSDPkgManager) Name() string {
+	return "OpenBSD Package Manager"
+}
+
+func (o *OpenBSDPkgManager) List() ([]Package, error) {
+	cmd, err := o.conn.RunCommand("pkg_info -a")
+	if err != nil {
+		return nil, fmt.Errorf("could not read openbsd package list")
+	}
+
+	return ParseOpenbsdPackages(cmd.Stdout)
+}
+
+func (o *OpenBSDPkgManager) Available() (map[string]PackageUpdate, error) {
+	return map[string]PackageUpdate{}, nil
+}
+
+func (o *OpenBSDPkgManager) Files(name string, version string, arch string) ([]FileRecord, error) {
+	return nil, nil
+}

providers/os/resources/packages/openbsd_packages_test.go

@@ -0,0 +1,49 @@
+// Copyright (c) Mondoo, Inc.
+// SPDX-License-Identifier: BUSL-1.1
+
+package packages
+
+import (
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestParseOpenbsdPackages(t *testing.T) {
+	f, err := os.Open("testdata/openbsd-pkg-info.txt")
+	require.NoError(t, err)
+	defer f.Close()
+
+	pkgs, err := ParseOpenbsdPackages(f)
+	require.NoError(t, err)
+	assert.Equal(t, 11, len(pkgs))
+
+	// Test simple package
+	assert.Equal(t, "bash", pkgs[1].Name)
+	assert.Equal(t, "5.2.26", pkgs[1].Version)
+	assert.Equal(t, "GNU Bourne Again Shell", pkgs[1].Description)
+	assert.Equal(t, OpenbsdPkgFormat, pkgs[1].Format)
+
+	// Test package with pN revision suffix
+	assert.Equal(t, "bzip2", pkgs[2].Name)
+	assert.Equal(t, "1.0.8p0", pkgs[2].Version)
+
+	// Test package with pN revision suffix in version
+	assert.Equal(t, "python", pkgs[6].Name)
+	assert.Equal(t, "3.11.8p0", pkgs[6].Version)
+
+	// Test package with flavor suffix (vim-9.1.100-no_x11)
+	assert.Equal(t, "vim", pkgs[8].Name)
+	assert.Equal(t, "9.1.100-no_x11", pkgs[8].Version)
+
+	// Test package with hyphen in name (git-lfs)
+	assert.Equal(t, "git-lfs", pkgs[10].Name)
+	assert.Equal(t, "3.4.1", pkgs[10].Version)
+
+	// Verify all packages have the openbsd format
+	for _, pkg := range pkgs {
+		assert.Equal(t, OpenbsdPkgFormat, pkg.Format)
+	}
+}

providers/os/resources/packages/packages.go

@@ -135,6 +135,8 @@ func ResolveSystemPkgManagers(conn shared.Connection) ([]OperatingSystemPkgManag
 		pms = append(pms, &FreeBSDPkgManager{conn: conn})
 	case asset.Platform.Name == "netbsd":
 		pms = append(pms, &NetBSDPkgManager{conn: conn})
+	case asset.Platform.Name == "openbsd":
+		pms = append(pms, &OpenBSDPkgManager{conn: conn})
 	case asset.Platform.Name == "aix":
 		pms = append(pms, &AixPkgManager{conn: conn, platform: asset.Platform})
 	case asset.Platform.Name == "gentoo":

providers/os/resources/packages/testdata/openbsd-pkg-info.txt

@@ -0,0 +1,11 @@
+aom-3.7.0           AV1 codec library
+bash-5.2.26         GNU Bourne Again Shell
+bzip2-1.0.8p0       block-sorting file compressor, unencumbered
+curl-8.6.0          command line tool for transferring data with URL syntax
+git-2.44.0          distributed version control system
+nano-7.2            small and friendly text editor, strstrippeddown Pico clone
+python-3.11.8p0     interpreted object-oriented programming language
+quirks-7.14         exceptions to the ports tree
+vim-9.1.100-no_x11  vi clone, many additional features
+xz-5.4.5            LZMA compression and decompression tools
+git-lfs-3.4.1       Git extension for versioning large files