✨ Use debian package list as evidence instead of its contents. (#5399)

* ✨ Use debian package list as evidence instead of its contents.

Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>

* Check if dpkg list file exists before adding it as evidence of package.

Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>

---------

Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>

Author: VasilSirakov

providers/os/resources/packages/dpkg_packages.go

@@ -217,36 +217,20 @@ func (dpm *DebPkgManager) Available() (map[string]PackageUpdate, error) {
 func (dpm *DebPkgManager) Files(name string, version string, arch string) ([]FileRecord, error) {
 	fs := dpm.conn.FileSystem()
 
-	files := []string{
+	dpkgListFiles := []string{
 		"/var/lib/dpkg/info/" + name + ".list",
 	}
+
 	if arch != "" {
-		files = append(files, "/var/lib/dpkg/info/"+name+":"+arch+".list")
+		dpkgListFiles = append(dpkgListFiles, "/var/lib/dpkg/info/"+name+":"+arch+".list")
 	}
 
 	fileRecords := []FileRecord{}
-	for i := range files {
-		file := files[i]
-		_, err := fs.Stat(file)
-		if err != nil {
+	for _, file := range dpkgListFiles {
+		if _, err := fs.Stat(file); err != nil {
 			continue
 		}
-
-		fi, err := fs.Open(file)
-		if err != nil {
-			return nil, err
-		}
-		defer fi.Close()
-
-		scanner := bufio.NewScanner(fi)
-		for scanner.Scan() {
-			line := scanner.Text()
-			fileRecords = append(fileRecords, FileRecord{
-				Path: line,
-			})
-		}
-		// we only need the first file that exists
-		break
+		fileRecords = append(fileRecords, FileRecord{Path: file})
 	}
 
 	return fileRecords, nil

providers/os/resources/packages/dpkg_packages_test.go

@@ -116,9 +116,8 @@ It was originally inspired by the Multics SubSystem library.`,
 	}
 	pkgFiles, err := mgr.Files(p.Name, p.Version, p.Arch)
 	require.NoError(t, err)
-	assert.Equal(t, 11, len(pkgFiles), "detected the right amount of package files")
-	assert.Contains(t, pkgFiles, FileRecord{Path: "/lib/aarch64-linux-gnu/libss.so.2.0"})
-	assert.Contains(t, pkgFiles, FileRecord{Path: "/lib/aarch64-linux-gnu/libss.so.2"})
+	assert.Equal(t, 1, len(pkgFiles), "detected the right amount of package files")
+	assert.Contains(t, pkgFiles, FileRecord{Path: "/var/lib/dpkg/info/libss2:amd64.list"})
 }
 
 func TestDpkgParserStatusD(t *testing.T) {