Fallback any linux system to use systemd (#6201)

This way we don't have to add every new Linux distro to this list. The
majority of the ecosystem is systemd at this point and we can track
anything that isn't systemd.

Signed-off-by: Tim Smith <tsmith84@gmail.com>

Author: tas50

providers/os/detector/detector_platform_test.go

@@ -1011,7 +1011,7 @@ func TestEndeavourOSContainerDetector(t *testing.T) {
 	assert.Equal(t, []string{"arch", "linux", "unix", "os"}, di.Family)
 }
 
-func TestCumulusContainerDetector(t *testing.T) {
+func TestCumulusOSDetector(t *testing.T) {
 	di, err := detectPlatformFromMock("./testdata/detect-cumulus.toml")
 	assert.Nil(t, err, "was able to create the provider")
 
@@ -1020,3 +1020,13 @@ func TestCumulusContainerDetector(t *testing.T) {
 	assert.Equal(t, "x86_64", di.Arch, "os arch should be identified")
 	assert.Equal(t, []string{"debian", "linux", "unix", "os"}, di.Family)
 }
+
+func TestNobaraDetector(t *testing.T) {
+	di, err := detectPlatformFromMock("./testdata/detect-nobara.toml")
+	assert.Nil(t, err, "was able to create the provider")
+
+	assert.Equal(t, "nobara", di.Name, "os name should be identified")
+	assert.Equal(t, "Nobara Linux 40 (KDE Plasma)", di.Title, "os title should be identified")
+	assert.Equal(t, "x86_64", di.Arch, "os arch should be identified")
+	assert.Equal(t, []string{"redhat", "linux", "unix", "os"}, di.Family)
+}

providers/os/resources/groups/manager_test.go

@@ -16,7 +16,7 @@ import (
 func TestManagerDebian(t *testing.T) {
 	mock, err := mock.New(0, &inventory.Asset{
 		Platform: &inventory.Platform{
-			Family: []string{"unix", "linux", "debian"},
+			Family: []string{"debian", "linux", "unix", "os"},
 		},
 	}, mock.WithPath("./testdata/debian.toml"))
 	require.NoError(t, err)
@@ -38,7 +38,7 @@ func TestManagerDebian(t *testing.T) {
 func TestManagerMacos(t *testing.T) {
 	mock, err := mock.New(0, &inventory.Asset{
 		Platform: &inventory.Platform{
-			Family: []string{"darwin"},
+			Family: []string{"darwin", "bsd", "unix", "os"},
 		},
 	}, mock.WithPath("./testdata/osx.toml"))
 	require.NoError(t, err)
@@ -60,7 +60,7 @@ func TestManagerMacos(t *testing.T) {
 func TestManagerFreebsd(t *testing.T) {
 	mock, err := mock.New(0, &inventory.Asset{
 		Platform: &inventory.Platform{
-			Family: []string{"unix", "bsd"},
+			Family: []string{"bsd", "unix", "os"},
 		},
 	}, mock.WithPath("./testdata/freebsd12.toml"))
 	require.NoError(t, err)
@@ -82,7 +82,7 @@ func TestManagerFreebsd(t *testing.T) {
 func TestManagerWindows(t *testing.T) {
 	mock, err := mock.New(0, &inventory.Asset{
 		Platform: &inventory.Platform{
-			Family: []string{"windows"},
+			Family: []string{"windows", "os"},
 		},
 	}, mock.WithPath("./testdata/windows.toml"))
 	require.NoError(t, err)

providers/os/resources/services/launchd_test.go

@@ -18,7 +18,7 @@ func TestParseServiceLaunchD(t *testing.T) {
 			Name:   "macos",
 			Family: []string{"unix", "darwin"},
 		},
-	}, mock.WithPath("./testdata/osx.toml"))
+	}, mock.WithPath("./testdata/macos.toml"))
 	if err != nil {
 		t.Fatal(err)
 	}

providers/os/resources/services/manager.go

@@ -73,16 +73,12 @@ func ResolveManager(conn shared.Connection) (OSServiceManager, error) {
 	switch {
 	case useNoopInit:
 		osm = &noopOsServiceManager{}
-	case asset.Platform.IsFamily("arch"): // arch family
-		osm = ResolveSystemdServiceManager(conn)
 	case asset.Platform.Name == "amazonlinux":
 		if amazonlinux1version.MatchString(asset.Platform.Version) {
 			osm = &UpstartServiceManager{SysVServiceManager{conn: conn}}
 		} else {
 			osm = ResolveSystemdServiceManager(conn)
 		}
-	case asset.Platform.Name == "photon":
-		osm = ResolveSystemdServiceManager(conn)
 	// NOTE: we need to check fedora before rhel family, since its also rhel family
 	case asset.Platform.Name == "fedora":
 		rv := detector.ParseOsVersion(asset.Platform.Version)
@@ -132,8 +128,6 @@ func ResolveManager(conn shared.Connection) (OSServiceManager, error) {
 		} else {
 			osm = ResolveSystemdServiceManager(conn)
 		}
-	case asset.Platform.Name == "raspbian" || asset.Platform.Name == "parrot": // debian based distros that have always been systemd
-		osm = ResolveSystemdServiceManager(conn)
 	case asset.Platform.Name == "suse-microos" || asset.Platform.Name == "opensuse-microos": // suse family but uses a different version scheme
 		osm = ResolveSystemdServiceManager(conn)
 	case asset.Platform.IsFamily("suse"):
@@ -161,29 +155,9 @@ func ResolveManager(conn shared.Connection) (OSServiceManager, error) {
 		osm = &OpenrcServiceManager{conn: conn}
 	case asset.Platform.Name == "gentoo":
 		osm = &OpenrcServiceManager{conn: conn}
-	case asset.Platform.Name == "cos":
-		osm = ResolveSystemdServiceManager(conn)
 	case asset.Platform.Name == "aix":
 		osm = &AixServiceManager{conn: conn}
-	case asset.Platform.IsFamily("euler"):
-		osm = ResolveSystemdServiceManager(conn)
-	case asset.Platform.Name == "kali": // debian based with versions from 2015 onwards being systemd based
-		osm = ResolveSystemdServiceManager(conn)
-	case asset.Platform.Name == "mageia": // mageia 2 and later are systemd based
-		osm = ResolveSystemdServiceManager(conn)
-	case asset.Platform.Name == "cloudlinux": // rhel based
-		osm = ResolveSystemdServiceManager(conn)
-	case asset.Platform.Name == "elementary": // ubuntu based
-		osm = ResolveSystemdServiceManager(conn)
-	case asset.Platform.Name == "mx": // debian based
-		osm = ResolveSystemdServiceManager(conn)
-	case asset.Platform.Name == "zorin": // ubuntu based
-		osm = ResolveSystemdServiceManager(conn)
-	case asset.Platform.Name == "cumulus-linux": // debian based
-		osm = ResolveSystemdServiceManager(conn)
-	case asset.Platform.Name == "nobara": // fedora based
-		osm = ResolveSystemdServiceManager(conn)
-	case asset.Platform.Name == "flatcar":
+	case asset.Platform.IsFamily("linux"): // fallback for other linux distros which we assume are systemd
 		osm = ResolveSystemdServiceManager(conn)
 	}