Skip to content

Commit 7d0dce7

Browse files
🧹 Do not fail packages fetching if dotnet packages retrieval fails. (#5849)
Signed-off-by: Preslav <preslav@mondoo.com>
1 parent 5b5f289 commit 7d0dce7

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

‎providers/os/resources/packages/windows_packages.go‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -256,10 +256,10 @@ func (w *WinPkgManager) getLocalInstalledApps() ([]Package, error) {
256256
// They do not show up in the general apps or features list, so we need to discover them separately
257257
dotNetFramework, err := w.getDotNetFramework()
258258
if err != nil {
259-
return nil, err
259+
log.Debug().Err(err).Msg("could not get .NET Framework packages from registry")
260+
} else {
261+
packages = append(packages, dotNetFramework...)
260262
}
261-
packages = append(packages, dotNetFramework...)
262-
263263
return packages, nil
264264
}
265265

@@ -405,10 +405,10 @@ func (w *WinPkgManager) getFsInstalledApps() ([]Package, error) {
405405
// They do not show up in the general apps or features list, so we need to discover them separately
406406
dotNetFramework, err := w.getDotNetFrameworkFs()
407407
if err != nil {
408-
return nil, err
408+
log.Debug().Err(err).Msg("could not get .NET Framework packages from filesystem")
409+
} else {
410+
packages = append(packages, dotNetFramework...)
409411
}
410-
packages = append(packages, dotNetFramework...)
411-
412412
msSqlHotfixes := findMsSqlHotfixes(packages)
413413
if len(msSqlHotfixes) > 0 {
414414
packages = updateMsSqlPackages(packages, msSqlHotfixes[len(msSqlHotfixes)-1])

0 commit comments

Comments
 (0)