address comments

Signed-off-by: Ivan Milchev <ivan@mondoo.com>

Author: imilchev

providers-sdk/v1/vault/cache/cached_vault.go

@@ -44,6 +44,10 @@ func (c *cachedVault) Set(ctx context.Context, s *vault.Secret) (*vault.SecretID
 }
 
 func (c *cachedVault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	res, err := c.vault.Delete(ctx, id)
+	if err != nil {
+		return nil, err
+	}
 	delete(c.secrets, id.Key)
-	return c.vault.Delete(ctx, id)
+	return res, nil
 }

providers-sdk/v1/vault/inmemory/inmemory.go

@@ -62,5 +62,13 @@ func (v *inmemoryVault) Get(ctx context.Context, id *vault.SecretID) (*vault.Sec
 }
 
 func (v *inmemoryVault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
-	return nil, vault.NotImplementedError
+	if id == nil {
+		return nil, errors.New("secret id is empty")
+	}
+
+	if _, ok := v.secrets[id.Key]; !ok {
+		return nil, vault.NotFoundError
+	}
+	delete(v.secrets, id.Key)
+	return &vault.Empty{}, nil
 }