Skip to content

Commit 8d18b12

Browse files
tas50claude
andcommitted
🧹 use NilData for unset serviceConnectNamespace
Distinguishes "not configured" from "configured but empty" per review. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 1503459 commit 8d18b12

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

providers/aws/resources/aws_ecs.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,8 @@ func initAwsEcsCluster(runtime *plugin.Runtime, args map[string]*llx.RawData) (m
232232
map[string]*llx.RawData{
233233
"__id": llx.StringData(clusterArn + "/capacityProviderStrategy/" + cpName),
234234
"capacityProvider": llx.StringDataPtr(item.CapacityProvider),
235-
"base": llx.IntData(int64(item.Base)),
236-
"weight": llx.IntData(int64(item.Weight)),
235+
"base": llx.IntData(int64(item.Base)),
236+
"weight": llx.IntData(int64(item.Weight)),
237237
})
238238
if err != nil {
239239
return nil, nil, err
@@ -245,7 +245,7 @@ func initAwsEcsCluster(runtime *plugin.Runtime, args map[string]*llx.RawData) (m
245245
if c.ServiceConnectDefaults != nil {
246246
args["serviceConnectNamespace"] = llx.StringDataPtr(c.ServiceConnectDefaults.Namespace)
247247
} else {
248-
args["serviceConnectNamespace"] = llx.StringData("")
248+
args["serviceConnectNamespace"] = llx.NilData
249249
}
250250

251251
return args, nil, nil

0 commit comments

Comments
 (0)