Fix formatting to prevent

=== Errors
Error: providers-sdk/v1/lr/docs/docs.go:56:21: non-constant format string in call to fmt.Sprintf

Error: cli/components/list.go:51:48: non-constant format string in call to fmt.Fprintf

Error: apps/cnquery/cmd/bundle.go:103:28: non-constant format string in call to fmt.Fprintf

Error: apps/cnquery/cmd/bundle.go:141:28: non-constant format string in call to fmt.Fprintf

Error: providers-sdk/v1/inventory/asset.go:44:22: non-constant format string in call to fmt.Sprintf
Signed-off-by: Christian Zunker <christian@mondoo.com>

Author: czunker

apps/cnquery/cmd/bundle.go

@@ -100,7 +100,7 @@ var queryPackLintCmd = &cobra.Command{
 		if len(errors) > 0 {
 			log.Error().Msg("could not validate query pack")
 			for i := range errors {
-				fmt.Fprintf(os.Stderr, stringx.Indent(2, errors[i]))
+				fmt.Fprint(os.Stderr, stringx.Indent(2, errors[i]))
 			}
 			cmd.SilenceUsage = true
 			cmd.SilenceErrors = true
@@ -138,7 +138,7 @@ var queryPackPublishCmd = &cobra.Command{
 		if len(bundleErrors) > 0 {
 			log.Error().Msg("could not validate query pack")
 			for i := range bundleErrors {
-				fmt.Fprintf(os.Stderr, stringx.Indent(2, bundleErrors[i]))
+				fmt.Fprint(os.Stderr, stringx.Indent(2, bundleErrors[i]))
 			}
 			cmd.SilenceUsage = true
 			cmd.SilenceErrors = true

cli/components/list.go

@@ -48,7 +48,7 @@ func (d itemDelegate) Render(w io.Writer, m list.Model, index int, listItem list
 		}
 	}
 
-	fmt.Fprintf(w, fn(str))
+	fmt.Fprint(w, fn(str))
 }
 
 type listModel struct {

providers-sdk/v1/inventory/asset.go

@@ -19,6 +19,7 @@ var assetPrintableKeys = []string{"name", "platform-id"}
 func (a *Asset) PrintableKeys() []string {
 	return assetPrintableKeys
 }
+
 func (a *Asset) PrintableValue(index int) string {
 	switch assetPrintableKeys[index] {
 	case "name":
@@ -41,7 +42,7 @@ func (a *Asset) HumanName() string {
 	}
 
 	if a.Platform != nil {
-		return fmt.Sprintf(a.Name + " (" + a.Platform.Title + ")")
+		return fmt.Sprint(a.Name + " (" + a.Platform.Title + ")")
 	}
 
 	return a.Name

providers-sdk/v1/lr/docs/docs.go

@@ -53,7 +53,7 @@ type LrDocsDocumentation struct {
 }
 
 func (d LrDocsDocumentation) MarshalGo() string {
-	return fmt.Sprintf("Description: " + strconv.Quote(d.Description) + ",\n")
+	return fmt.Sprint("Description: " + strconv.Quote(d.Description) + ",\n")
 }
 
 type LrDocsRefs struct {

providers/os/resources/auditpol.go

@@ -22,7 +22,7 @@ func (p *mqlAuditpol) list() ([]interface{}, error) {
 	cmd := o.(*mqlPowershell)
 	out := cmd.GetStdout()
 	if out.Error != nil {
-		return nil, fmt.Errorf("could not run auditpol: " + out.Error.Error())
+		return nil, fmt.Errorf("could not run auditpol: %s", out.Error.Error())
 	}
 
 	entries, err := windows.ParseAuditpol(strings.NewReader(out.Data))

providers/os/resources/pam/parser.go

@@ -37,7 +37,7 @@ func ParseLine(line string) (*PamLine, error) {
 	}
 
 	if len(fields) < 3 {
-		return &PamLine{}, fmt.Errorf("Invalid pam entry" + line)
+		return &PamLine{}, fmt.Errorf("Invalid pam entry: %s", line)
 	}
 
 	// parse modules

providers/os/resources/secpol.go

@@ -33,7 +33,7 @@ func (s *mqlSecpol) policy() (*windows.Secpol, error) {
 	cmd := o.(*mqlCommand)
 	out := cmd.GetStdout()
 	if out.Error != nil {
-		return nil, fmt.Errorf("could not run auditpol: " + out.Error.Error())
+		return nil, fmt.Errorf("could not run auditpol: %s", out.Error.Error())
 	}
 
 	policy, err := windows.ParseSecpol(strings.NewReader(out.Data))