fix: compile-time panic when .sample is called on a array-like resource (e.g. users)

slntopp · slntopp · commit bbfa9335f715 · 2025-12-08T18:58:24.000+01:00
Example: `users.where(false).sample()`
diff --git a/mqlc/builtin_resource.go b/mqlc/builtin_resource.go
@@ -199,7 +199,7 @@ func compileResourceSample(c *compiler, typ types.Type, ref uint64, id string, c
 		return types.Nil, multierr.Wrap(err, "failed to compile "+id)
 	}
 
-	if call == nil {
+	if call == nil || len(call.Function) == 0 {
 		return types.Nil, errors.New("missing argument for calling '" + id + "'")
 	}
 	if len(call.Function) > 1 {

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ func compileResourceSample(c *compiler, typ types.Type, ref uint64, id string, c`
`199`	`199`	`return types.Nil, multierr.Wrap(err, "failed to compile "+id)`
`200`	`200`	`}`
`201`	`201`
`202`		`- if call == nil {`
	`202`	`+ if call == nil \|\| len(call.Function) == 0 {`
`203`	`203`	`return types.Nil, errors.New("missing argument for calling '" + id + "'")`
`204`	`204`	`}`
`205`	`205`	`if len(call.Function) > 1 {`