🐛 Propagate AutoUpdate to all runtimes + avoid reinstalling deps (#5510)

This change fixes a number of things from our latest release:

* Removes hardcoded `AutoUpdate` setting and uses the config
* Avoids re-installing already installed dependencies
* Propagates the setting `AutoUpdate` to all runtimes created with a parent via `NewRuntimeFrom()`

---------

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>

Author: afiune

explorer/scan/discovery_test.go

@@ -140,6 +140,13 @@ func TestDiscoverAssets(t *testing.T) {
 		}
 	}
 
+	runtime := providers.Coordinator.NewRuntime()
+	assert.Nil(t, providers.SetDefaultRuntime(runtime))
+	runtime.AutoUpdate = providers.UpdateProvidersConfig{
+		Enabled:         true,
+		RefreshInterval: 60 * 60,
+	}
+
 	t.Run("normal", func(t *testing.T) {
 		inv := getInventory()
 		discoveredAssets, err := DiscoverAssets(context.Background(), inv, nil, recording.Null{})

providers-sdk/v1/testutils/testutils.go

@@ -221,6 +221,11 @@ func Local() llx.Runtime {
 	schema.Add(mockprovider.Config.Name, mockSchema)
 
 	runtime := providers.Coordinator.NewRuntime()
+	_ = providers.SetDefaultRuntime(runtime)
+	runtime.AutoUpdate = providers.UpdateProvidersConfig{
+		Enabled:         false,
+		RefreshInterval: 60 * 60,
+	}
 
 	provider := &providers.RunningProvider{
 		Name:   osconf.Config.Name,

providers/coordinator.go

@@ -108,6 +108,9 @@ func (c *coordinator) newRuntime() *Runtime {
 		providers:       map[string]*ConnectedProvider{},
 		recording:       recording.Null{},
 		shutdownTimeout: defaultShutdownTimeout,
+		AutoUpdate: UpdateProvidersConfig{
+			Enabled: true,
+		},
 	}
 
 	c.mutex.Lock()
@@ -123,6 +126,7 @@ func (c *coordinator) newRuntime() *Runtime {
 func (c *coordinator) NewRuntimeFrom(parent *Runtime) *Runtime {
 	res := c.NewRuntime()
 	res.UpstreamConfig = parent.UpstreamConfig
+	res.AutoUpdate = parent.AutoUpdate
 	res.recording = parent.Recording()
 	for k, v := range parent.providers {
 		res.providers[k] = v

providers/providers.go

@@ -493,8 +493,8 @@ func installDependencies(provider *Provider, existing Providers) error {
 
 		// Check if dependency is already installed
 		depProvider := existing.Lookup(dependencyLookup)
-		if depProvider == nil {
-			continue
+		if depProvider != nil {
+			continue // exist
 		}
 
 		upstreamDep := DefaultProviders.Lookup(dependencyLookup)

providers/runtime.go

@@ -181,7 +181,7 @@ func (r *Runtime) providerForAsset(asset *inventory.Asset) (*Provider, error) {
 			conn.Type = inventory.ConnBackendToType(conn.Backend)
 		}
 
-		provider, err := EnsureProvider(ProviderLookup{ConnType: conn.Type}, true, r.coordinator.Providers())
+		provider, err := EnsureProvider(ProviderLookup{ConnType: conn.Type}, r.AutoUpdate.Enabled, r.coordinator.Providers())
 		if err != nil {
 			errs.Add(err)
 			continue